Privacy policy links for extended safe browsing reporting

Privacy policy links for extended safe browsing reporting

The extended safe browsing reporting opt-in should point to the whitepaper section on malware. This CL:
- Adds a "privacy policy" link to the dialog
- Updates the existing URL to point to the specific malware section instead of the generic privacy policy

BUG=383866
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277930

[felt, 2014-06-17 15:15:06]

hi scott, PTAL. thanks.

[sky, 2014-06-17 19:11:28]

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/download/download_feedback_dialog_view.cc (right):

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/download/download_feedback_dialog_view.cc:159:
navigator_->OpenURL(params);
How do you know navigator_ is still valid by the time you get here? Is this
object guaranteed to outlive navigator_?

[felt, 2014-06-17 20:27:31]

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/download/download_feedback_dialog_view.cc (right):

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/download/download_feedback_dialog_view.cc:159:
navigator_->OpenURL(params);
On 2014/06/17 19:11:28, sky wrote:
> How do you know navigator_ is still valid by the time you get here? Is this
> object guaranteed to outlive navigator_?

The navigator is from the download shelf, which won't close until this dialog is
dealt with. That means that navigator_ will be valid as long as the
DownloadFeedbackDialogView object exists. I could add a DCHECK or if(navigator_)
if you feel one or the other is appropriate.

[sky, 2014-06-17 23:54:41]

LGTM

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/download/download_feedback_dialog_view.cc (right):

https://codereview.chromium.org/339073003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/download/download_feedback_dialog_view.cc:159:
navigator_->OpenURL(params);
On 2014/06/17 20:27:31, felt wrote:
> On 2014/06/17 19:11:28, sky wrote:
> > How do you know navigator_ is still valid by the time you get here? Is this
> > object guaranteed to outlive navigator_?
> 
> The navigator is from the download shelf, which won't close until this dialog
is
> dealt with. That means that navigator_ will be valid as long as the
> DownloadFeedbackDialogView object exists. I could add a DCHECK or
if(navigator_)
> if you feel one or the other is appropriate.

DCHECK(navigator_) wouldn't tell if you the object has since been deleted. If
you say the lifetime is guaranteed that's good enough.

[felt, 2014-06-17 23:57:57]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-06-17 23:59:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/339073003/20001

[commit-bot: I haz the power, 2014-06-18 00:51:33]

Change committed as 277930