Issue 339063003: Add invokeCallback functionality to the code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339063003: Add invokeCallback functionality to the code generator (Closed)

Created:
6 years, 6 months ago by kihong

Modified:
6 years, 6 months ago

Reviewers:
haraken, bashi

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add invokeCallback functionality to the code generator invokeCallback usually used for v8 generated codes. Only one exception is "MediaQueryListListener" which had been used it manually. But it has been removed by r176818 from "MediaQueryListListener". Therefore it does not need to keep in "V8Binding". BUG=388049 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176826

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -30 lines)			Patch
M	Source/bindings/scripts/v8_callback_interface.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/templates/callback_interface.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCallbackInterface.cpp	View	11 chunks	+14 lines, -10 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kihong

On 2014/06/24 08:39:54, haraken wrote: > LGTM, nice clean-up. Thank you for reviewing :-)

6 years, 6 months ago (2014-06-24 09:06:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/339063003/1

6 years, 6 months ago (2014-06-24 09:07:02 UTC) #5

Message was sent while issue was closed.

Change committed as 176826

Expand Messages | Collapse Messages