Issue 339063002: Fix the BubbleFrameView close button insets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339063002: Fix the BubbleFrameView close button insets. (Closed)

Created:
6 years, 6 months ago by msw

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina, Evan Stade

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the BubbleFrameView close button insets. Set the button size after setting the border. (this takes the updated insets into account) Refine BubbleFrameView's title bar layout calculations. Return the close button's right inset in GetTitleInsets. See before/after pics on the bug (expected is with this CL). BUG=385422 TEST=Views dialogs place the (x) close button correctly. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277822

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
	M	ui/views/bubble/bubble_frame_view.cc	View		4 chunks	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/339063002/1

6 years, 6 months ago (2014-06-17 16:05:06 UTC) #4

Message was sent while issue was closed.

Change committed as 277822

Expand Messages | Collapse Messages