Fixing polymer element registration when extending tag extensions

pkg/polymer/lib/src/declaration.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /**
  * **Warning**: this class is experiental and subject to change.
  *
  * The implementation for the `polymer-element` element.
@@ skipping 154 matching lines @@
     // setting resource paths. e.g.
     // this.$.image.src = this.resolvePath('images/foo.png')
     // Potentially remove when spec bug is addressed.
     // https://www.w3.org/Bugs/Public/show_bug.cgi?id=21407
     // TODO(jmesserly): resolvePath not ported, see first comment in this class.
 
     // under ShadowDOMPolyfill, transforms to approximate missing CSS features
     _shimShadowDomStyling(templateContent, name);
 
     // register our custom element
-    registerType(name, extendsTag: extendee);
+    registerType(name);
 
     // NOTE: skip in Dart because we don't have mutable global scope.
     // reference constructor in a global named by 'constructor' attribute
     // publishConstructor();
   }
 
   /**
    * Gets the Dart type registered for this name, and sets up declarative
    * features. Fills in the [type] and [supertype] fields.
    *
@@ skipping 41 matching lines @@
     // TODO(jmesserly): this feels unnatrual in Dart. Since we have convenient
     // lazy static initialization, can we get by without it?
     var registered = cls.methods[#registerCallback];
     if (registered != null && registered.isStatic &&
         registered.isRegularMethod) {
       cls.invoke(#registerCallback, [this]);
     }
 
   }
 
-  void registerType(String name, {String extendsTag}) {
+  void registerType(String name) {

[Jennifer Messerly, 2013/10/22 21:41:47]

retroactive question: why don't we pass in "extendee" from the caller?

Polymer uses that in the "register" function ... if the value is unreliable, it
will be a problem up there too. I suspect either this search-up-the-chain is
unnecessary, or if it is necessary, it should happen sooner...

+    var baseTag;
+    var decl = this;
+    while (decl != null) {
+      baseTag = decl.attributes['extends'];
+      decl = decl.superDeclaration;
+    }
     // native element must be specified in extends
-    var nativeExtends = (extendsTag != null && !extendsTag.contains('-')) ?
-        extendsTag : null;
+    var nativeExtends = baseTag;

[Siggi Cherem (dart-lang), 2013/10/22 16:44:17]

nit: merge baseTag or nativeExtends to use a single variable?

     document.register(name, type, extendsTag: nativeExtends);
   }
 
   void publishAttributes(ClassMirror cls, PolymerDeclaration superDecl) {
     // get properties to publish
     if (superDecl != null && superDecl._publish != null) {
       _publish = new Map.from(superDecl._publish);
     }
     _publish = _getProperties(cls, _publish, (x) => x is PublishedProperty);
 
@@ skipping 426 matching lines @@
   return map;
 }();
 
 // Dart note: we need this function because we have additional renames JS does
 // not have. The JS renames are simply case differences, whereas we have ones
 // like doubleclick -> dblclick and stripping the webkit prefix.
 String _eventNameFromType(String eventType) {
   final result = _reverseEventTranslations[eventType];
   return result != null ? result : eventType;
 }