Issue 339023003: Make 'Disconnect from google account' dialog box shows correct message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339023003: Make 'Disconnect from google account' dialog box shows correct message (Closed)

Created:
6 years, 6 months ago by kaliamoorthi

Modified:
6 years, 6 months ago

Reviewers:
Bernhard Bauer, Andrew T Wilson (Slow)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make 'Disconnect from Google account' dialog box show correct message This CL makes 'Disconnect from Google account' dialog show the correct message in all usage scenarios. Further, the cancel button is made the default in the dialog. BUG=374715, 374723 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277792

Patch Set 1 : Version 0 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -10 lines)			Patch
M	chrome/browser/resources/options/browser_options.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/manage_profile_overlay.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/manage_profile_overlay.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/manage_profile_handler.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/manage_profile_handler.cc	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui_browsertest.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/339023003/20001

6 years, 6 months ago (2014-06-17 15:24:37 UTC) #4

Message was sent while issue was closed.

Change committed as 277792

Expand Messages | Collapse Messages