Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 339013002: LeakExpectations: Add more serviceworker tests and Battery Status API leak. (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

LeakExpectations: Add more serviceworker tests and Battery Status API leak. bonus: sort entries on serviceworker expectations section. NOTRY=true BUG=385384, 364390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M LayoutTests/LeakExpectations View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
Would you rubberstamp this?
6 years, 6 months ago (2014-06-17 00:03:51 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-17 00:04:52 UTC) #2
kouhei (in TOK)
Thanks!
6 years, 6 months ago (2014-06-17 00:05:33 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-17 00:05:35 UTC) #4
tkent
It's ok to apply TBR= for FooExpectations files changes.
6 years, 6 months ago (2014-06-17 00:05:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/339013002/1
6 years, 6 months ago (2014-06-17 00:06:18 UTC) #6
commit-bot: I haz the power
Change committed as 176255
6 years, 6 months ago (2014-06-17 00:06:52 UTC) #7
haraken
6 years, 6 months ago (2014-06-17 00:34:08 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698