Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339003002: Add new metrics to rappor.xml (Closed)

Created:
6 years, 6 months ago by Steven Holte
Modified:
6 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add new metrics to rappor.xml BUG=381325 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278035

Patch Set 1 #

Patch Set 2 : Recording time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M tools/metrics/rappor/rappor.xml View 1 1 chunk +30 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steven Holte
6 years, 6 months ago (2014-06-16 23:47:22 UTC) #1
Alexei Svitkine (slow)
LGTM For all of these, can you mention when they're recorded? (e.g. profile load)
6 years, 6 months ago (2014-06-17 15:52:54 UTC) #2
Steven Holte
The CQ bit was checked by holte@chromium.org
6 years, 6 months ago (2014-06-17 19:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/holte@chromium.org/339003002/20001
6 years, 6 months ago (2014-06-17 19:14:27 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 11:45:05 UTC) #5
Message was sent while issue was closed. 
Change committed as 278035

Powered by Google App Engine
This is Rietveld 408576698