Add a clang/mac bot to the FYI waterfall.

Add a clang/mac bot to the FYI waterfall. 

It only builds Chromium.app for now, no unit test binaries.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60697

[Nico, 2010-09-27 18:02:30]

Needs to be rebaselined on top of evan's CL once that's in.

The plan is to have a symlink to the clang++ binary in /usr/local/bin.

[Mark Mentovai, 2010-09-27 18:04:01]

Can we do this so that the clang we use is checked in, and the bot that does the
build can sync it?

[M-A Ruel, 2010-09-27 18:05:10]

lgtm, I'm fine with checking in clang the same way it's done with valgrind in a
later change.

[Evan Martin, 2010-09-27 18:07:19]

Ok, landed my change, please rebase

http://codereview.chromium.org/3390027/diff/7001/8003
File buildbot/scripts/slave/compile.py (right):

http://codereview.chromium.org/3390027/diff/7001/8003#newcode107
buildbot/scripts/slave/compile.py:107: env['CC'] = 'clang++'
Does that work?  At least on Linux we have code that must be compiled with gcc
and not g++, is my recollection.

[Nico, 2010-09-27 19:03:03]

Mark: You mean check in the binary? If so, will do in a follow-up.

http://codereview.chromium.org/3390027/diff/7001/8003
File buildbot/scripts/slave/compile.py (right):

http://codereview.chromium.org/3390027/diff/7001/8003#newcode107
buildbot/scripts/slave/compile.py:107: env['CC'] = 'clang++'
On 2010/09/27 18:07:19, Evan Martin wrote:
> Does that work?  At least on Linux we have code that must be compiled with gcc
> and not g++, is my recollection.

Yes, it works. xcode uses $CC for all compilations and passes a -x c++ to it.
the ++ is needed to link in the c++ libs.

[Mark Mentovai, 2010-09-27 19:05:01]

thakis@chromium.org wrote:
> Mark: You mean check in the binary? If so, will do in a follow-up.

Yes, LGTM.

> Yes, it works. xcode uses $CC for all compilations and passes a -x c++
> to it. the ++ is needed to link in the c++ libs.

Can you follow Xcode’s lead and use the non-plusplus binary name for
this? Xcode invokes “gcc -x c,” “gcc -x c++” and friends, not “g++ -x
c,”

[Evan Martin, 2010-09-27 19:05:58]

FWIW, I don't think it's worth checking in a binary until we have a real builder
for this (ETA like one month).  Otherwise it depends on Nico's workstation
anyway.

[Nico, 2010-09-27 19:06:02]

On Mon, Sep 27, 2010 at 12:04 PM, Mark Mentovai <mark@chromium.org> wrote:
> thakis@chromium.org wrote:
>> Mark: You mean check in the binary? If so, will do in a follow-up.
>
> Yes, LGTM.
>
>> Yes, it works. xcode uses $CC for all compilations and passes a -x c++
>> to it. the ++ is needed to link in the c++ libs.
>
> Can you follow Xcode’s lead and use the non-plusplus binary name for
> this? Xcode invokes “gcc -x c,” “gcc -x c++” and friends, not “g++ -x
> c,”

As far as I remember, I got linker errors when doing this because
XCode also uses $CC for linking.

[Nico, 2010-09-27 19:09:36]

On Mon, Sep 27, 2010 at 12:05 PM,  <evan@chromium.org> wrote:
> FWIW, I don't think it's worth checking in a binary until we have a real
> builder
> for this (ETA like one month).  Otherwise it depends on Nico's workstation
> anyway.

I have a os x builder I can use (codf62).