Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7225)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 338993007: Track when and how a profile is signed out via UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove tracking android in separate UMA bucket Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc
index 7e71099760de32741241536d032a4f58bf537b81..49954d8568115156ed4b83f9a71a7955b6a77a6d 100644
--- a/chrome/browser/ui/webui/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler.cc
@@ -42,6 +42,7 @@
#include "chrome/common/url_constants.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
#include "components/signin/core/browser/signin_error_controller.h"
+#include "components/signin/core/browser/signin_metrics.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/sync_driver/sync_prefs.h"
#include "content/public/browser/render_view_host.h"
@@ -805,6 +806,7 @@ void SyncSetupHandler::HandleStartSignin(const base::ListValue* args) {
void SyncSetupHandler::HandleStopSyncing(const base::ListValue* args) {
if (GetSyncService())
ProfileSyncService::SyncEvent(ProfileSyncService::STOP_FROM_OPTIONS);
+ signin_metrics::LogSignout(signin_metrics::USER_CLICKED_SIGNOUT);
SigninManagerFactory::GetForProfile(GetProfile())->SignOut();
Evan Stade 2014/06/19 01:55:12 I think you should make SignOut take a parameter (
Mike Lerman 2014/06/19 17:55:48 Done.
bool delete_profile = false;
@@ -849,8 +851,10 @@ void SyncSetupHandler::CloseSyncSetup() {
// Sign out the user on desktop Chrome if they click cancel during
// initial setup.
// TODO(rsimha): Revisit this for M30. See http://crbug.com/252049.
- if (sync_service->FirstSetupInProgress())
+ if (sync_service->FirstSetupInProgress()) {
+ signin_metrics::LogSignout(signin_metrics::ABORT_SIGNIN);
SigninManagerFactory::GetForProfile(GetProfile())->SignOut();
+ }
#endif
}
}

Powered by Google App Engine
This is Rietveld 408576698