Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5768)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 338993007: Track when and how a profile is signed out via UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: SignOut() param in Android tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | chrome/browser/ui/webui/sync_setup_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 2353921c46179af2c444a2504b985c48074954e4..d1f4e7961c2df121f4f8893f2e40426882192479 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -38,6 +38,7 @@
#include "chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h"
#include "chrome/common/url_constants.h"
#include "components/signin/core/browser/signin_manager.h"
+#include "components/signin/core/browser/signin_metrics.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/sync_driver/sync_prefs.h"
#include "grit/chromium_strings.h"
@@ -279,7 +280,7 @@ void OneClickSigninSyncStarter::CompleteInitForNewProfile(
// the signin for the original profile was cancelled (must do this after
// we have called Initialize() with the new profile, as otherwise this
// object will get freed when the signin on the old profile is cancelled.
- old_signin_manager->SignOut();
+ old_signin_manager->SignOut(signin_metrics::TRANSFER_CREDENTIALS);
// Load policy for the just-created profile - once policy has finished
// loading the signin process will complete.
@@ -306,7 +307,8 @@ void OneClickSigninSyncStarter::CompleteInitForNewProfile(
#endif
void OneClickSigninSyncStarter::CancelSigninAndDelete() {
- SigninManagerFactory::GetForProfile(profile_)->SignOut();
+ SigninManagerFactory::GetForProfile(profile_)->SignOut(
+ signin_metrics::ABORT_SIGNIN);
// The statement above results in a call to SigninFailed() which will free
// this object, so do not refer to the OneClickSigninSyncStarter object
// after this point.
« no previous file with comments | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | chrome/browser/ui/webui/sync_setup_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698