Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 338993006: DevTools: pass agent host id to the renderer (Blink). (Closed)

Created:
6 years, 6 months ago by pfeldman
Modified:
6 years, 6 months ago
Reviewers:
eustas, vsevik
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: pass agent host id to the renderer (Blink). NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176408

Patch Set 1 #

Patch Set 2 : Same w/ reattach. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -17 lines) Patch
M Source/core/inspector/InspectorController.h View 1 4 chunks +5 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 5 chunks +12 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 4 chunks +16 lines, -6 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M public/web/WebDevToolsAgentClient.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
lgtm
6 years, 6 months ago (2014-06-18 08:59:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/338993006/20001
6 years, 6 months ago (2014-06-18 08:59:45 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 10:46:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12472)
6 years, 6 months ago (2014-06-18 10:46:35 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-06-18 11:46:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/338993006/20001
6 years, 6 months ago (2014-06-18 11:47:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 11:48:47 UTC) #7
Message was sent while issue was closed.
Change committed as 176408

Powered by Google App Engine
This is Rietveld 408576698