Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: trunk/Source/web/PopupListBox.cpp

Issue 338993005: Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/platform/scroll/FramelessScrollView.cpp ('k') | trunk/Source/web/tests/PopupMenuTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/web/PopupListBox.cpp
===================================================================
--- trunk/Source/web/PopupListBox.cpp (revision 176308)
+++ trunk/Source/web/PopupListBox.cpp (working copy)
@@ -349,7 +349,7 @@
{
// Adjust coords for scrolled frame.
IntRect r = intersection(rect, frameRect());
- int tx = x() - scrollX() + ((shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar() && !verticalScrollbar()->isOverlayScrollbar()) ? verticalScrollbar()->width() : 0);
+ int tx = x() - scrollX() + ((shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar()) ? verticalScrollbar()->width() : 0);
int ty = y() - scrollY();
r.move(-tx, -ty);
@@ -596,7 +596,7 @@
// Invalidate in the window contents, as FramelessScrollView::invalidateRect
// paints in the window coordinates.
IntRect clipRect = contentsToWindow(getRowBounds(index));
- if (shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar() && !verticalScrollbar()->isOverlayScrollbar())
+ if (shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar())
clipRect.move(verticalScrollbar()->width(), 0);
invalidateRect(clipRect);
}
@@ -773,8 +773,7 @@
// Set our widget and scrollable contents sizes.
int scrollbarWidth = 0;
if (m_visibleRows < numItems()) {
- if (!ScrollbarTheme::theme()->usesOverlayScrollbars())
- scrollbarWidth = ScrollbarTheme::theme()->scrollbarThickness();
+ scrollbarWidth = ScrollbarTheme::theme()->scrollbarThickness();
// Use minEndOfLinePadding when there is a scrollbar so that we use
// as much as (lineEndPaddingWidth - minEndOfLinePadding) padding
« no previous file with comments | « trunk/Source/platform/scroll/FramelessScrollView.cpp ('k') | trunk/Source/web/tests/PopupMenuTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698