Issue 338993005: Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338993005: Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..." (Closed)

Created:
6 years, 6 months ago by haraken

Modified:
6 years, 6 months ago

Reviewers:
pals

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..." This broke webkit_unit_tests in Android bots: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14135 > Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled. > > The content should take total window width while overlay-scrollbar is enabled. > > BUG=382900 > > Review URL: https://codereview.chromium.org/333633003 TBR=sanjoy.pal@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176309

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -87 lines)			Patch
M	trunk/Source/platform/scroll/FramelessScrollView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/web/PopupListBox.cpp	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/Source/web/tests/PopupMenuTest.cpp	View	7 chunks	+2 lines, -44 lines	0 comments	Download
D	trunk/Source/web/tests/data/popup/select_rtl.html	View	1 chunk	+0 lines, -38 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r176309.