Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 338993005: Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..." (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
Reviewers:
pals
CC:
blink-reviews
Visibility:
Public.

Description

Revert 176261 "Fix for select PopupMenuList appearance in rtl mo..." This broke webkit_unit_tests in Android bots: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14135 > Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled. > > The content should take total window width while overlay-scrollbar is enabled. > > BUG=382900 > > Review URL: https://codereview.chromium.org/333633003 TBR=sanjoy.pal@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -87 lines) Patch
M trunk/Source/platform/scroll/FramelessScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/web/PopupListBox.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/Source/web/tests/PopupMenuTest.cpp View 7 chunks +2 lines, -44 lines 0 comments Download
D trunk/Source/web/tests/data/popup/select_rtl.html View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 6 months ago (2014-06-17 12:46:16 UTC) #1
haraken
6 years, 6 months ago (2014-06-17 12:46:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r176309.

Powered by Google App Engine
This is Rietveld 408576698