Issue 338993004: [TaskManager] Check iterators' availabilities before manipulating them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338993004: [TaskManager] Check iterators' availabilities before manipulating them. (Closed)

Created:
6 years, 6 months ago by peria

Modified:
6 years, 6 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[TaskManager] Check iterators' availability before manipulating them. There are some DCHECK() to check iterators, but it checks nothing in release builds. We have to check them to avoid crashes in release builds. BUG=364243 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277963

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
	M	chrome/browser/task_manager/task_manager.cc	View		3 chunks	+16 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/338993004/20001

6 years, 6 months ago (2014-06-17 20:57:48 UTC) #3

Message was sent while issue was closed.

Change committed as 277963

Expand Messages | Collapse Messages