Source/core/frame/LocalFrame.cpp - Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Throw in a call to relaxAdoptionRequirement Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 11d77a1994498a37f25d7161129b24fa3f67acf9..f58763d00cd87d7926c7068587bdbce1c4ee7045 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -106,9 +106,6 @@ inline LocalFrame::LocalFrame(FrameLoaderClient* client, FrameHost* host, FrameO

PassRefPtr<LocalFrame> LocalFrame::create(FrameLoaderClient* client, FrameHost* host, FrameOwner* owner)

{

RefPtr<LocalFrame> frame = adoptRef(new LocalFrame(client, host, owner));

- // FIXME: Why is this here? RemoteFrames need this too.

- if (!frame->owner())

- frame->page()->setMainFrame(frame);

InspectorInstrumentation::frameAttachedToParent(frame.get());

return frame.release();

}