Source/web/WebViewImpl.cpp - Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Throw in a call to relaxAdoptionRequirement Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index c12b34326755f4c749bdbf89cd9d4c9c6ca70930..74abeff0172446b09e0b63394f761a32f4bee950 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2492,9 +2492,7 @@ void WebViewImpl::setPageEncoding(const WebString& encodingName)

WebFrame* WebViewImpl::mainFrame()

{

- // FIXME: This should be updated so it can return both WebLocalFrames and

- // WebRemoteFrames. Right now, it only returns WebLocalFrames.

- return mainFrameImpl();

+ return WebFrame::fromFrame(m_page ? m_page->mainFrame() : 0);

}

WebFrame* WebViewImpl::findFrameByName(