Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2074)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Refine comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index bee41e1ef522f5a3e573eab14a5597b7def78498..0df2268e7da720cce54081806e790d66c5c9fa3f 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -245,24 +245,6 @@ void WebRemoteFrameImpl::removeChild(WebFrame* frame)
m_ownersForChildren.remove(frame);
}
-WebFrame* WebRemoteFrameImpl::traversePrevious(bool wrap) const
-{
- ASSERT_NOT_REACHED();
- return 0;
-}
-
-WebFrame* WebRemoteFrameImpl::traverseNext(bool wrap) const
-{
- ASSERT_NOT_REACHED();
- return 0;
-}
-
-WebFrame* WebRemoteFrameImpl::findChildByName(const WebString&) const
-{
- ASSERT_NOT_REACHED();
- return 0;
-}
-
WebDocument WebRemoteFrameImpl::document() const
{
ASSERT_NOT_REACHED();
@@ -839,5 +821,12 @@ void WebRemoteFrameImpl::setWebCoreFrame(PassRefPtr<RemoteFrame> frame)
m_frame = frame;
}
+WebRemoteFrameImpl* WebRemoteFrameImpl::fromFrame(RemoteFrame& frame)
+{
+ if (!frame.client())
+ return 0;
+ return static_cast<RemoteFrameClient*>(frame.client())->webFrame();
+}
+
} // namespace blink
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698