Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: Source/web/WebRemoteFrameImpl.h

Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Refine comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "public/web/WebRemoteFrame.h" 8 #include "public/web/WebRemoteFrame.h"
9 #include "web/RemoteFrameClient.h" 9 #include "web/RemoteFrameClient.h"
10 #include "wtf/HashMap.h" 10 #include "wtf/HashMap.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 virtual void setScrollOffset(const WebSize&) OVERRIDE; 43 virtual void setScrollOffset(const WebSize&) OVERRIDE;
44 virtual WebSize minimumScrollOffset() const OVERRIDE; 44 virtual WebSize minimumScrollOffset() const OVERRIDE;
45 virtual WebSize maximumScrollOffset() const OVERRIDE; 45 virtual WebSize maximumScrollOffset() const OVERRIDE;
46 virtual WebSize contentsSize() const OVERRIDE; 46 virtual WebSize contentsSize() const OVERRIDE;
47 virtual bool hasVisibleContent() const OVERRIDE; 47 virtual bool hasVisibleContent() const OVERRIDE;
48 virtual WebRect visibleContentRect() const OVERRIDE; 48 virtual WebRect visibleContentRect() const OVERRIDE;
49 virtual bool hasHorizontalScrollbar() const OVERRIDE; 49 virtual bool hasHorizontalScrollbar() const OVERRIDE;
50 virtual bool hasVerticalScrollbar() const OVERRIDE; 50 virtual bool hasVerticalScrollbar() const OVERRIDE;
51 virtual WebView* view() const OVERRIDE; 51 virtual WebView* view() const OVERRIDE;
52 virtual void removeChild(WebFrame*) OVERRIDE; 52 virtual void removeChild(WebFrame*) OVERRIDE;
53 virtual WebFrame* traversePrevious(bool wrap) const OVERRIDE;
54 virtual WebFrame* traverseNext(bool wrap) const OVERRIDE;
55 virtual WebFrame* findChildByName(const WebString&) const OVERRIDE;
56 virtual WebDocument document() const OVERRIDE; 53 virtual WebDocument document() const OVERRIDE;
57 virtual WebPerformance performance() const OVERRIDE; 54 virtual WebPerformance performance() const OVERRIDE;
58 virtual bool dispatchBeforeUnloadEvent() OVERRIDE; 55 virtual bool dispatchBeforeUnloadEvent() OVERRIDE;
59 virtual void dispatchUnloadEvent() OVERRIDE; 56 virtual void dispatchUnloadEvent() OVERRIDE;
60 virtual NPObject* windowObject() const OVERRIDE; 57 virtual NPObject* windowObject() const OVERRIDE;
61 virtual void bindToWindowObject(const WebString& name, NPObject*) OVERRIDE; 58 virtual void bindToWindowObject(const WebString& name, NPObject*) OVERRIDE;
62 virtual void bindToWindowObject(const WebString& name, NPObject*, void*) OVE RRIDE; 59 virtual void bindToWindowObject(const WebString& name, NPObject*, void*) OVE RRIDE;
63 virtual void executeScript(const WebScriptSource&) OVERRIDE; 60 virtual void executeScript(const WebScriptSource&) OVERRIDE;
64 virtual void executeScriptInIsolatedWorld( 61 virtual void executeScriptInIsolatedWorld(
65 int worldID, const WebScriptSource* sources, unsigned numSources, 62 int worldID, const WebScriptSource* sources, unsigned numSources,
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 virtual WebString layerTreeAsText(bool showDebugInfo = false) const OVERRIDE ; 174 virtual WebString layerTreeAsText(bool showDebugInfo = false) const OVERRIDE ;
178 175
179 virtual WebLocalFrame* createLocalChild(const WebString& name, WebFrameClien t*) OVERRIDE; 176 virtual WebLocalFrame* createLocalChild(const WebString& name, WebFrameClien t*) OVERRIDE;
180 virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebFrameCli ent*) OVERRIDE; 177 virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebFrameCli ent*) OVERRIDE;
181 178
182 void initializeAsMainFrame(WebCore::Page*); 179 void initializeAsMainFrame(WebCore::Page*);
183 180
184 void setWebCoreFrame(PassRefPtr<WebCore::RemoteFrame>); 181 void setWebCoreFrame(PassRefPtr<WebCore::RemoteFrame>);
185 WebCore::RemoteFrame* frame() const { return m_frame.get(); } 182 WebCore::RemoteFrame* frame() const { return m_frame.get(); }
186 183
184 static WebRemoteFrameImpl* fromFrame(WebCore::RemoteFrame&);
185
187 private: 186 private:
188 RemoteFrameClient m_frameClient; 187 RemoteFrameClient m_frameClient;
189 RefPtr<WebCore::RemoteFrame> m_frame; 188 RefPtr<WebCore::RemoteFrame> m_frame;
190 189
191 HashMap<WebFrame*, OwnPtr<WebCore::FrameOwner> > m_ownersForChildren; 190 HashMap<WebFrame*, OwnPtr<WebCore::FrameOwner> > m_ownersForChildren;
192 }; 191 };
193 192
194 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 193 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
195 194
196 } // namespace blink 195 } // namespace blink
197 196
198 #endif // WebRemoteFrameImpl_h 197 #endif // WebRemoteFrameImpl_h
OLDNEW
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698