Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 338993003: Cleanup various WebView/WebFrame APIs to properly handle remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Refine comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "web/WebRemoteFrameImpl.h" 6 #include "web/WebRemoteFrameImpl.h"
7 7
8 #include "core/frame/FrameOwner.h" 8 #include "core/frame/FrameOwner.h"
9 #include "core/frame/RemoteFrame.h" 9 #include "core/frame/RemoteFrame.h"
10 #include "public/platform/WebFloatRect.h" 10 #include "public/platform/WebFloatRect.h"
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 ASSERT_NOT_REACHED(); 238 ASSERT_NOT_REACHED();
239 return 0; 239 return 0;
240 } 240 }
241 241
242 void WebRemoteFrameImpl::removeChild(WebFrame* frame) 242 void WebRemoteFrameImpl::removeChild(WebFrame* frame)
243 { 243 {
244 WebFrame::removeChild(frame); 244 WebFrame::removeChild(frame);
245 m_ownersForChildren.remove(frame); 245 m_ownersForChildren.remove(frame);
246 } 246 }
247 247
248 WebFrame* WebRemoteFrameImpl::traversePrevious(bool wrap) const
249 {
250 ASSERT_NOT_REACHED();
251 return 0;
252 }
253
254 WebFrame* WebRemoteFrameImpl::traverseNext(bool wrap) const
255 {
256 ASSERT_NOT_REACHED();
257 return 0;
258 }
259
260 WebFrame* WebRemoteFrameImpl::findChildByName(const WebString&) const
261 {
262 ASSERT_NOT_REACHED();
263 return 0;
264 }
265
266 WebDocument WebRemoteFrameImpl::document() const 248 WebDocument WebRemoteFrameImpl::document() const
267 { 249 {
268 ASSERT_NOT_REACHED(); 250 ASSERT_NOT_REACHED();
269 return WebDocument(); 251 return WebDocument();
270 } 252 }
271 253
272 WebPerformance WebRemoteFrameImpl::performance() const 254 WebPerformance WebRemoteFrameImpl::performance() const
273 { 255 {
274 ASSERT_NOT_REACHED(); 256 ASSERT_NOT_REACHED();
275 return WebPerformance(); 257 return WebPerformance();
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 child->setWebCoreFrame(childFrame); 814 child->setWebCoreFrame(childFrame);
833 childFrame->tree().setName(name, AtomicString()); 815 childFrame->tree().setName(name, AtomicString());
834 return child; 816 return child;
835 } 817 }
836 818
837 void WebRemoteFrameImpl::setWebCoreFrame(PassRefPtr<RemoteFrame> frame) 819 void WebRemoteFrameImpl::setWebCoreFrame(PassRefPtr<RemoteFrame> frame)
838 { 820 {
839 m_frame = frame; 821 m_frame = frame;
840 } 822 }
841 823
824 WebRemoteFrameImpl* WebRemoteFrameImpl::fromFrame(RemoteFrame& frame)
825 {
826 if (!frame.client())
827 return 0;
828 return static_cast<RemoteFrameClient*>(frame.client())->webFrame();
829 }
830
842 } // namespace blink 831 } // namespace blink
843 832
OLDNEW
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698