Cleanup various WebView/WebFrame APIs to properly handle remote frames.

Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 638 matching lines @@
     if (WebFrame::opener() && !opener && m_client)
         m_client->didDisownOpener(this);
 
     WebFrame::setOpener(opener);
 
     ASSERT(m_frame);
     if (m_frame && m_frame->document())
         m_frame->document()->initSecurityContext();
 }
 
-// FIXME: These methods should move into WebFrame once FrameTree is no longer
-// dependent on LocalFrame.
-void WebLocalFrameImpl::appendChild(WebFrame* child)
-{
-    WebFrame::appendChild(child);
-    frame()->tree().invalidateScopedChildCount();
-}
-
-void WebLocalFrameImpl::removeChild(WebFrame* child)
-{
-    WebFrame::removeChild(child);
-    frame()->tree().invalidateScopedChildCount();
-}
-
-WebFrame* WebLocalFrameImpl::traversePrevious(bool wrap) const
-{
-    if (!frame())
-        return 0;
-    // FIXME: This should move to WebFrame and become local/remote agnostic.
-    Frame* prevFrame = frame()->tree().traversePreviousWithWrap(wrap);
-    if (!prevFrame || !prevFrame->isLocalFrame())
-        return 0;
-    return fromFrame(toLocalFrame(prevFrame));
-}
-
-WebFrame* WebLocalFrameImpl::traverseNext(bool wrap) const
-{
-    // FIXME: This should move to WebFrame and become local/remote agnostic.
-    if (!frame())
-        return 0;
-    // FIXME: This should move to WebFrame and become local/remote agnostic.
-    Frame* nextFrame = frame()->tree().traverseNextWithWrap(wrap);
-    if (!nextFrame || !nextFrame->isLocalFrame())
-        return 0;
-    return fromFrame(toLocalFrame(nextFrame));
-}
-
-WebFrame* WebLocalFrameImpl::findChildByName(const WebString& name) const
-{
-    // FIXME: This should move to WebFrame and become local/remote agnostic.
-    if (!frame())
-        return 0;
-    // FIXME: This should move to WebFrame and become local/remote agnostic.
-    Frame* child = frame()->tree().child(name);
-    if (!child || !child->isLocalFrame())
-        return 0;
-    return fromFrame(toLocalFrame(child));
-}
-
 WebDocument WebLocalFrameImpl::document() const
 {
     if (!frame() || !frame()->document())
         return WebDocument();
     return WebDocument(frame()->document());
 }
 
 WebPerformance WebLocalFrameImpl::performance() const
 {
     if (!frame())
@@ skipping 1001 matching lines @@
     frame()->view()->setInputEventsTransformForEmulation(m_inputEventsOffsetForEmulation, m_inputEventsScaleFactorForEmulation);
 
     if (isMainFrame)
         webView->suppressInvalidations(false);
 }
 
 WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame* frame)
 {
     if (!frame)
         return 0;
-    FrameLoaderClient* client = frame->loader().client();
+    return fromFrame(*frame);
+}
+
+WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame& frame)
+{
+    FrameLoaderClient* client = frame.loader().client();
     if (!client || !client->isFrameLoaderClientImpl())
         return 0;
     return toFrameLoaderClientImpl(client)->webFrame();
 }
 
 WebLocalFrameImpl* WebLocalFrameImpl::fromFrameOwnerElement(Element* element)
 {
     // FIXME: Why do we check specifically for <iframe> and <frame> here? Why can't we get the WebLocalFrameImpl from an <object> element, for example.
     if (!isHTMLFrameElementBase(element))
         return 0;
@@ skipping 210 matching lines @@
 {
     RefPtr<LocalFrame> frame = LocalFrame::create(&m_frameLoaderClientImpl, host, owner);
     setWebCoreFrame(frame);
     frame->tree().setName(name, fallbackName);
     // May dispatch JS events; frame may be detached after this.
     frame->init();
     return frame;
 }
 
 } // namespace blink