Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 338993002: [webcrypto] exportKey() now returns dictionary when format='jwk' (CL 2 of 2). (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

[webcrypto] exportKey() now returns a dictionary when format='jwk' (CL 2 of 2). Previously it would return an array buffer of the JSON. This corresponds with the recent spec update: https://dvcs.w3.org/hg/webcrypto-api/rev/f61017a76a5d BUG=373917, 245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176371

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase onto master (earlier version was based on 311733004 but hasn't landed yet) #

Patch Set 3 : Don't use v8AtomicString() #

Patch Set 4 : Rebase and fix rsa-oaep-key-manipulation.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
M LayoutTests/crypto/aes-export-key.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/hmac-export-key.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/jwk-export-use-values.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/rsa-export-key.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/rsa-export-private-key.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/rsa-oaep-key-manipulation.html View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.cpp View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M Source/platform/CryptoResult.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/exported/WebCryptoResult.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eroman
This is the final API change I need to make before can enable webcrypto for ...
6 years, 6 months ago (2014-06-16 23:37:32 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp File Source/modules/crypto/CryptoResultImpl.cpp (right): https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp#newcode125 Source/modules/crypto/CryptoResultImpl.cpp:125: v8::Handle<v8::String> jsonString = v8AtomicString(scriptState->isolate(), utf8Data, length); Why atomic?
6 years, 6 months ago (2014-06-17 05:03:05 UTC) #2
abarth-chromium
On 2014/06/16 at 23:37:32, eroman wrote: > This is the final API change I need ...
6 years, 6 months ago (2014-06-17 05:03:12 UTC) #3
eroman
https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp File Source/modules/crypto/CryptoResultImpl.cpp (right): https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp#newcode125 Source/modules/crypto/CryptoResultImpl.cpp:125: v8::Handle<v8::String> jsonString = v8AtomicString(scriptState->isolate(), utf8Data, length); On 2014/06/17 05:03:05, ...
6 years, 6 months ago (2014-06-17 17:58:03 UTC) #4
eroman
https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp File Source/modules/crypto/CryptoResultImpl.cpp (right): https://codereview.chromium.org/338993002/diff/1/Source/modules/crypto/CryptoResultImpl.cpp#newcode125 Source/modules/crypto/CryptoResultImpl.cpp:125: v8::Handle<v8::String> jsonString = v8AtomicString(scriptState->isolate(), utf8Data, length); On 2014/06/17 17:58:02, ...
6 years, 6 months ago (2014-06-17 18:06:56 UTC) #5
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-17 21:50:37 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-17 22:28:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/338993002/40001
6 years, 6 months ago (2014-06-17 22:28:44 UTC) #8
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 6 months ago (2014-06-17 23:35:06 UTC) #9
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-18 00:00:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/338993002/60001
6 years, 6 months ago (2014-06-18 00:01:36 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 01:10:42 UTC) #12
Message was sent while issue was closed.
Change committed as 176371

Powered by Google App Engine
This is Rietveld 408576698