In Debug, SkMutex(pthread) crashes on re-entrant aquire from same thread.

In Debug, SkMutex(pthread) crashes on re-entrant aquire from same thread.

Committed: https://skia.googlesource.com/skia/+/e486ec48b1dbdc6e8276a765abeb8eabcbf5c22e

[hal.canary, 2014-06-20 15:29:13]

ptal

[mtklein, 2014-06-20 15:34:31]

lgtm

https://codereview.chromium.org/338973006/diff/1/src/ports/SkMutex_pthread.h
File src/ports/SkMutex_pthread.h (right):

https://codereview.chromium.org/338973006/diff/1/src/ports/SkMutex_pthread.h#...
src/ports/SkMutex_pthread.h:22: SkASSERT(fOwner != pthread_self());  // SkMutex
is not re-entrant
Run this through the TSAN bot before submitting?  It may complain that this
isn't thread safe.  If so, wrap fOwner is SK_ANNOTATE_UNPROTECTED_READ.

[hal.canary, 2014-06-20 15:42:04]

On 2014/06/20 15:34:31, mtklein wrote:

> Run this through the TSAN bot before submitting?  It may complain that this
> isn't thread safe.  If so, wrap fOwner is SK_ANNOTATE_UNPROTECTED_READ.

The bot is Release.  Should I still worry?

[mtklein, 2014-06-20 15:51:03]

On 2014/06/20 15:42:04, Hal Canary wrote:
> On 2014/06/20 15:34:31, mtklein wrote:
> 
> > Run this through the TSAN bot before submitting?  It may complain that this
> > isn't thread safe.  If so, wrap fOwner is SK_ANNOTATE_UNPROTECTED_READ.
> 
> The bot is Release.  Should I still worry?

Duh, nope.  That's one of the reasons I run it in release...

[mtklein, 2014-06-20 15:51:30]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-06-20 15:52:00]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/338973006/1

[commit-bot: I haz the power, 2014-06-20 16:06:00]

Change committed as e486ec48b1dbdc6e8276a765abeb8eabcbf5c22e