Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/code-stubs.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 0ac07de0ddfd93a262a6a6fc544c113de3962181..b96013306c3658be32f60aa048afa56a71ab8504 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -585,9 +585,9 @@ void JSEntryStub::FinishCode(Handle<Code> code) {
void KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { KeyedLoadIC::ReceiverRegister(),
- KeyedLoadIC::NameRegister() };
- STATIC_ASSERT(KeyedLoadIC::kRegisterArgumentCount == 2);
+ Register registers[] = { LoadIC::ReceiverRegister(),
+ LoadIC::NameRegister() };
+ STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
descriptor->Initialize(ARRAY_SIZE(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -595,9 +595,9 @@ void KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
void KeyedLoadDictionaryElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { KeyedLoadIC::ReceiverRegister(),
- KeyedLoadIC::NameRegister() };
- STATIC_ASSERT(KeyedLoadIC::kRegisterArgumentCount == 2);
+ Register registers[] = { LoadIC::ReceiverRegister(),
+ LoadIC::NameRegister() };
+ STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
descriptor->Initialize(ARRAY_SIZE(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -605,9 +605,9 @@ void KeyedLoadDictionaryElementStub::InitializeInterfaceDescriptor(
void KeyedLoadGenericElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { KeyedLoadIC::ReceiverRegister(),
- KeyedLoadIC::NameRegister() };
- STATIC_ASSERT(KeyedLoadIC::kRegisterArgumentCount == 2);
+ Register registers[] = { LoadIC::ReceiverRegister(),
+ LoadIC::NameRegister() };
+ STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
descriptor->Initialize(
ARRAY_SIZE(registers), registers,
Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry);
@@ -623,7 +623,7 @@ void LoadFieldStub::InitializeInterfaceDescriptor(
void KeyedLoadFieldStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { KeyedLoadIC::ReceiverRegister() };
+ Register registers[] = { LoadIC::ReceiverRegister() };
descriptor->Initialize(ARRAY_SIZE(registers), registers);
}
@@ -638,8 +638,8 @@ void StringLengthStub::InitializeInterfaceDescriptor(
void KeyedStringLengthStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { KeyedLoadIC::ReceiverRegister(),
- KeyedLoadIC::NameRegister() };
+ Register registers[] = { LoadIC::ReceiverRegister(),
+ LoadIC::NameRegister() };
descriptor->Initialize(ARRAY_SIZE(registers), registers);
}
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698