src/ia32/debug-ia32.cc - Issue 338963003: KeyedLoadIC should have same register spec as LoadIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/debug-ia32.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ARM and ARM64 ports. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/debug-ia32.cc

diff --git a/src/ia32/debug-ia32.cc b/src/ia32/debug-ia32.cc

index e64190591321e129393f9712ac3eb4724e929384..68cf0dd1e742add897ffbd27aab4e83bc29fc48f 100644

--- a/src/ia32/debug-ia32.cc

+++ b/src/ia32/debug-ia32.cc

@@ -200,9 +200,7 @@ void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {

void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {

// Register state for keyed IC load call (from ic-ia32.cc).

- Register receiver = KeyedLoadIC::ReceiverRegister();

- Register name = KeyedLoadIC::NameRegister();

- Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0, false);

+ GenerateLoadICDebugBreak(masm);

}