Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/ic-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 3268 matching lines...) Expand 10 before | Expand all | Expand 10 after
3279 return Operand(elements_pointer_reg, 3279 return Operand(elements_pointer_reg,
3280 ToRegister(key), 3280 ToRegister(key),
3281 scale_factor, 3281 scale_factor,
3282 offset); 3282 offset);
3283 } 3283 }
3284 } 3284 }
3285 3285
3286 3286
3287 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) { 3287 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {
3288 ASSERT(ToRegister(instr->context()).is(rsi)); 3288 ASSERT(ToRegister(instr->context()).is(rsi));
3289 ASSERT(ToRegister(instr->object()).is(KeyedLoadIC::ReceiverRegister())); 3289 ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister()));
3290 ASSERT(ToRegister(instr->key()).is(KeyedLoadIC::NameRegister())); 3290 ASSERT(ToRegister(instr->key()).is(LoadIC::NameRegister()));
3291 3291
3292 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize(); 3292 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
3293 CallCode(ic, RelocInfo::CODE_TARGET, instr); 3293 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3294 } 3294 }
3295 3295
3296 3296
3297 void LCodeGen::DoArgumentsElements(LArgumentsElements* instr) { 3297 void LCodeGen::DoArgumentsElements(LArgumentsElements* instr) {
3298 Register result = ToRegister(instr->result()); 3298 Register result = ToRegister(instr->result());
3299 3299
3300 if (instr->hydrogen()->from_inlined()) { 3300 if (instr->hydrogen()->from_inlined()) {
(...skipping 2542 matching lines...) Expand 10 before | Expand all | Expand 10 after
5843 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5843 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5844 RecordSafepoint(Safepoint::kNoLazyDeopt); 5844 RecordSafepoint(Safepoint::kNoLazyDeopt);
5845 } 5845 }
5846 5846
5847 5847
5848 #undef __ 5848 #undef __
5849 5849
5850 } } // namespace v8::internal 5850 } } // namespace v8::internal
5851 5851
5852 #endif // V8_TARGET_ARCH_X64 5852 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/ic-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698