Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: src/x64/debug-x64.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 // -- rcx : name 175 // -- rcx : name
176 // -- rdx : receiver 176 // -- rdx : receiver
177 // ----------------------------------- 177 // -----------------------------------
178 Generate_DebugBreakCallHelper( 178 Generate_DebugBreakCallHelper(
179 masm, rax.bit() | rcx.bit() | rdx.bit(), 0, false); 179 masm, rax.bit() | rcx.bit() | rdx.bit(), 0, false);
180 } 180 }
181 181
182 182
183 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 183 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
184 // Register state for keyed IC load call (from ic-x64.cc). 184 // Register state for keyed IC load call (from ic-x64.cc).
185 Register receiver = KeyedLoadIC::ReceiverRegister(); 185 GenerateLoadICDebugBreak(masm);
186 Register name = KeyedLoadIC::NameRegister();
187 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0, false);
188 } 186 }
189 187
190 188
191 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 189 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
192 // Register state for keyed IC load call (from ic-x64.cc). 190 // Register state for keyed IC load call (from ic-x64.cc).
193 // ----------- S t a t e ------------- 191 // ----------- S t a t e -------------
194 // -- rax : value 192 // -- rax : value
195 // -- rcx : key 193 // -- rcx : key
196 // -- rdx : receiver 194 // -- rdx : receiver
197 // ----------------------------------- 195 // -----------------------------------
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 __ jmp(rdx); 301 __ jmp(rdx);
304 } 302 }
305 303
306 const bool LiveEdit::kFrameDropperSupported = true; 304 const bool LiveEdit::kFrameDropperSupported = true;
307 305
308 #undef __ 306 #undef __
309 307
310 } } // namespace v8::internal 308 } } // namespace v8::internal
311 309
312 #endif // V8_TARGET_ARCH_X64 310 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698