Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/ia32/lithium-codegen-ia32.h" 10 #include "src/ia32/lithium-codegen-ia32.h"
(...skipping 2186 matching lines...) Expand 10 before | Expand all | Expand 10 after
2197 // LCodeGen::DoLoadKeyedFixedArray 2197 // LCodeGen::DoLoadKeyedFixedArray
2198 instr->RequiresHoleCheck()) { 2198 instr->RequiresHoleCheck()) {
2199 result = AssignEnvironment(result); 2199 result = AssignEnvironment(result);
2200 } 2200 }
2201 return result; 2201 return result;
2202 } 2202 }
2203 2203
2204 2204
2205 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) { 2205 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2206 LOperand* context = UseFixed(instr->context(), esi); 2206 LOperand* context = UseFixed(instr->context(), esi);
2207 LOperand* object = UseFixed(instr->object(), KeyedLoadIC::ReceiverRegister()); 2207 LOperand* object = UseFixed(instr->object(), LoadIC::ReceiverRegister());
2208 LOperand* key = UseFixed(instr->key(), KeyedLoadIC::NameRegister()); 2208 LOperand* key = UseFixed(instr->key(), LoadIC::NameRegister());
2209 2209
2210 LLoadKeyedGeneric* result = 2210 LLoadKeyedGeneric* result =
2211 new(zone()) LLoadKeyedGeneric(context, object, key); 2211 new(zone()) LLoadKeyedGeneric(context, object, key);
2212 return MarkAsCall(DefineFixed(result, eax), instr); 2212 return MarkAsCall(DefineFixed(result, eax), instr);
2213 } 2213 }
2214 2214
2215 2215
2216 LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) { 2216 LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) {
2217 ElementsKind elements_kind = instr->elements_kind(); 2217 ElementsKind elements_kind = instr->elements_kind();
2218 2218
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
2667 LOperand* function = UseRegisterAtStart(instr->function()); 2667 LOperand* function = UseRegisterAtStart(instr->function());
2668 LAllocateBlockContext* result = 2668 LAllocateBlockContext* result =
2669 new(zone()) LAllocateBlockContext(context, function); 2669 new(zone()) LAllocateBlockContext(context, function);
2670 return MarkAsCall(DefineFixed(result, esi), instr); 2670 return MarkAsCall(DefineFixed(result, esi), instr);
2671 } 2671 }
2672 2672
2673 2673
2674 } } // namespace v8::internal 2674 } } // namespace v8::internal
2675 2675
2676 #endif // V8_TARGET_ARCH_IA32 2676 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698