Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 // -- ecx : name 193 // -- ecx : name
194 // -- edx : receiver 194 // -- edx : receiver
195 // ----------------------------------- 195 // -----------------------------------
196 Generate_DebugBreakCallHelper( 196 Generate_DebugBreakCallHelper(
197 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false); 197 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false);
198 } 198 }
199 199
200 200
201 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 201 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
202 // Register state for keyed IC load call (from ic-ia32.cc). 202 // Register state for keyed IC load call (from ic-ia32.cc).
203 Register receiver = KeyedLoadIC::ReceiverRegister(); 203 GenerateLoadICDebugBreak(masm);
204 Register name = KeyedLoadIC::NameRegister();
205 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0, false);
206 } 204 }
207 205
208 206
209 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 207 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
210 // Register state for keyed IC load call (from ic-ia32.cc). 208 // Register state for keyed IC load call (from ic-ia32.cc).
211 // ----------- S t a t e ------------- 209 // ----------- S t a t e -------------
212 // -- eax : value 210 // -- eax : value
213 // -- ecx : key 211 // -- ecx : key
214 // -- edx : receiver 212 // -- edx : receiver
215 // ----------------------------------- 213 // -----------------------------------
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 } 321 }
324 322
325 323
326 const bool LiveEdit::kFrameDropperSupported = true; 324 const bool LiveEdit::kFrameDropperSupported = true;
327 325
328 #undef __ 326 #undef __
329 327
330 } } // namespace v8::internal 328 } } // namespace v8::internal
331 329
332 #endif // V8_TARGET_ARCH_IA32 330 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698