Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: src/arm64/lithium-codegen-arm64.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm64/lithium-codegen-arm64.h" 7 #include "src/arm64/lithium-codegen-arm64.h"
8 #include "src/arm64/lithium-gap-resolver-arm64.h" 8 #include "src/arm64/lithium-gap-resolver-arm64.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 3635 matching lines...) Expand 10 before | Expand all | Expand 10 after
3646 } else { 3646 } else {
3647 DeoptimizeIfRoot(result, Heap::kTheHoleValueRootIndex, 3647 DeoptimizeIfRoot(result, Heap::kTheHoleValueRootIndex,
3648 instr->environment()); 3648 instr->environment());
3649 } 3649 }
3650 } 3650 }
3651 } 3651 }
3652 3652
3653 3653
3654 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) { 3654 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {
3655 ASSERT(ToRegister(instr->context()).is(cp)); 3655 ASSERT(ToRegister(instr->context()).is(cp));
3656 ASSERT(ToRegister(instr->object()).is(KeyedLoadIC::ReceiverRegister())); 3656 ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister()));
3657 ASSERT(ToRegister(instr->key()).is(KeyedLoadIC::NameRegister())); 3657 ASSERT(ToRegister(instr->key()).is(LoadIC::NameRegister()));
3658 3658
3659 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize(); 3659 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
3660 CallCode(ic, RelocInfo::CODE_TARGET, instr); 3660 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3661 3661
3662 ASSERT(ToRegister(instr->result()).Is(x0)); 3662 ASSERT(ToRegister(instr->result()).Is(x0));
3663 } 3663 }
3664 3664
3665 3665
3666 void LCodeGen::DoLoadNamedField(LLoadNamedField* instr) { 3666 void LCodeGen::DoLoadNamedField(LLoadNamedField* instr) {
3667 HObjectAccess access = instr->hydrogen()->access(); 3667 HObjectAccess access = instr->hydrogen()->access();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
3699 } else { 3699 } else {
3700 __ Load(result, FieldMemOperand(source, offset), access.representation()); 3700 __ Load(result, FieldMemOperand(source, offset), access.representation());
3701 } 3701 }
3702 } 3702 }
3703 3703
3704 3704
3705 void LCodeGen::DoLoadNamedGeneric(LLoadNamedGeneric* instr) { 3705 void LCodeGen::DoLoadNamedGeneric(LLoadNamedGeneric* instr) {
3706 ASSERT(ToRegister(instr->context()).is(cp)); 3706 ASSERT(ToRegister(instr->context()).is(cp));
3707 // LoadIC expects name and receiver in registers. 3707 // LoadIC expects name and receiver in registers.
3708 ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister())); 3708 ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister()));
3709 ASSERT(ToRegister(instr->object()).is(x0));
3710 __ Mov(LoadIC::NameRegister(), Operand(instr->name())); 3709 __ Mov(LoadIC::NameRegister(), Operand(instr->name()));
3711 3710
3712 Handle<Code> ic = LoadIC::initialize_stub(isolate(), NOT_CONTEXTUAL); 3711 Handle<Code> ic = LoadIC::initialize_stub(isolate(), NOT_CONTEXTUAL);
3713 CallCode(ic, RelocInfo::CODE_TARGET, instr); 3712 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3714 3713
3715 ASSERT(ToRegister(instr->result()).is(x0)); 3714 ASSERT(ToRegister(instr->result()).is(x0));
3716 } 3715 }
3717 3716
3718 3717
3719 void LCodeGen::DoLoadRoot(LLoadRoot* instr) { 3718 void LCodeGen::DoLoadRoot(LLoadRoot* instr) {
(...skipping 2333 matching lines...) Expand 10 before | Expand all | Expand 10 after
6053 Handle<ScopeInfo> scope_info = instr->scope_info(); 6052 Handle<ScopeInfo> scope_info = instr->scope_info();
6054 __ Push(scope_info); 6053 __ Push(scope_info);
6055 __ Push(ToRegister(instr->function())); 6054 __ Push(ToRegister(instr->function()));
6056 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6055 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6057 RecordSafepoint(Safepoint::kNoLazyDeopt); 6056 RecordSafepoint(Safepoint::kNoLazyDeopt);
6058 } 6057 }
6059 6058
6060 6059
6061 6060
6062 } } // namespace v8::internal 6061 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698