Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/arm64/debug-arm64.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 // -- lr : return address 250 // -- lr : return address
251 // ----------------------------------- 251 // -----------------------------------
252 // Registers x0, x1, and x2 contain objects that need to be pushed on the 252 // Registers x0, x1, and x2 contain objects that need to be pushed on the
253 // expression stack of the fake JS frame. 253 // expression stack of the fake JS frame.
254 Generate_DebugBreakCallHelper(masm, x0.Bit() | x1.Bit() | x2.Bit(), 0, x10); 254 Generate_DebugBreakCallHelper(masm, x0.Bit() | x1.Bit() | x2.Bit(), 0, x10);
255 } 255 }
256 256
257 257
258 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 258 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
259 // Calling convention for keyed IC load (from ic-arm.cc). 259 // Calling convention for keyed IC load (from ic-arm.cc).
260 Register receiver = KeyedLoadIC::ReceiverRegister(); 260 GenerateLoadICDebugBreak(masm);
261 Register name = KeyedLoadIC::NameRegister();
262 Generate_DebugBreakCallHelper(masm, receiver.Bit() | name.Bit(), 0, x10);
263 } 261 }
264 262
265 263
266 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 264 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
267 // ---------- S t a t e -------------- 265 // ---------- S t a t e --------------
268 // -- x0 : value 266 // -- x0 : value
269 // -- x1 : key 267 // -- x1 : key
270 // -- x2 : receiver 268 // -- x2 : receiver
271 // -- lr : return address 269 // -- lr : return address
272 Generate_DebugBreakCallHelper(masm, x0.Bit() | x1.Bit() | x2.Bit(), 0, x10); 270 Generate_DebugBreakCallHelper(masm, x0.Bit() | x1.Bit() | x2.Bit(), 0, x10);
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 // Re-run JSFunction, x1 is function, cp is context. 372 // Re-run JSFunction, x1 is function, cp is context.
375 __ Br(scratch); 373 __ Br(scratch);
376 } 374 }
377 375
378 376
379 const bool LiveEdit::kFrameDropperSupported = true; 377 const bool LiveEdit::kFrameDropperSupported = true;
380 378
381 } } // namespace v8::internal 379 } } // namespace v8::internal
382 380
383 #endif // V8_TARGET_ARCH_ARM64 381 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698