Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-arm.h" 7 #include "src/arm/lithium-arm.h"
8 #include "src/arm/lithium-codegen-arm.h" 8 #include "src/arm/lithium-codegen-arm.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/lithium-allocator-inl.h" 10 #include "src/lithium-allocator-inl.h"
(...skipping 2313 matching lines...) Expand 10 before | Expand all | Expand 10 after
2324 // LCodeGen::DoLoadKeyedFixedArray 2324 // LCodeGen::DoLoadKeyedFixedArray
2325 instr->RequiresHoleCheck()) { 2325 instr->RequiresHoleCheck()) {
2326 result = AssignEnvironment(result); 2326 result = AssignEnvironment(result);
2327 } 2327 }
2328 return result; 2328 return result;
2329 } 2329 }
2330 2330
2331 2331
2332 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) { 2332 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2333 LOperand* context = UseFixed(instr->context(), cp); 2333 LOperand* context = UseFixed(instr->context(), cp);
2334 LOperand* object = UseFixed(instr->object(), KeyedLoadIC::ReceiverRegister()); 2334 LOperand* object = UseFixed(instr->object(), LoadIC::ReceiverRegister());
2335 LOperand* key = UseFixed(instr->key(), KeyedLoadIC::NameRegister()); 2335 LOperand* key = UseFixed(instr->key(), LoadIC::NameRegister());
2336 2336
2337 LInstruction* result = 2337 LInstruction* result =
2338 DefineFixed(new(zone()) LLoadKeyedGeneric(context, object, key), r0); 2338 DefineFixed(new(zone()) LLoadKeyedGeneric(context, object, key), r0);
2339 return MarkAsCall(result, instr); 2339 return MarkAsCall(result, instr);
2340 } 2340 }
2341 2341
2342 2342
2343 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 2343 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
2344 if (!instr->is_typed_elements()) { 2344 if (!instr->is_typed_elements()) {
2345 ASSERT(instr->elements()->representation().IsTagged()); 2345 ASSERT(instr->elements()->representation().IsTagged());
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
2720 LInstruction* LChunkBuilder::DoAllocateBlockContext( 2720 LInstruction* LChunkBuilder::DoAllocateBlockContext(
2721 HAllocateBlockContext* instr) { 2721 HAllocateBlockContext* instr) {
2722 LOperand* context = UseFixed(instr->context(), cp); 2722 LOperand* context = UseFixed(instr->context(), cp);
2723 LOperand* function = UseRegisterAtStart(instr->function()); 2723 LOperand* function = UseRegisterAtStart(instr->function());
2724 LAllocateBlockContext* result = 2724 LAllocateBlockContext* result =
2725 new(zone()) LAllocateBlockContext(context, function); 2725 new(zone()) LAllocateBlockContext(context, function);
2726 return MarkAsCall(DefineFixed(result, cp), instr); 2726 return MarkAsCall(DefineFixed(result, cp), instr);
2727 } 2727 }
2728 2728
2729 } } // namespace v8::internal 2729 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698