Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: src/arm/debug-arm.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 // -- lr : return address 191 // -- lr : return address
192 // ----------------------------------- 192 // -----------------------------------
193 // Registers r0, r1, and r2 contain objects that need to be pushed on the 193 // Registers r0, r1, and r2 contain objects that need to be pushed on the
194 // expression stack of the fake JS frame. 194 // expression stack of the fake JS frame.
195 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0); 195 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0);
196 } 196 }
197 197
198 198
199 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 199 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
200 // Calling convention for keyed IC load (from ic-arm.cc). 200 // Calling convention for keyed IC load (from ic-arm.cc).
201 Register receiver = KeyedLoadIC::ReceiverRegister(); 201 GenerateLoadICDebugBreak(masm);
202 Register name = KeyedLoadIC::NameRegister();
203 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0);
204 } 202 }
205 203
206 204
207 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 205 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
208 // ---------- S t a t e -------------- 206 // ---------- S t a t e --------------
209 // -- r0 : value 207 // -- r0 : value
210 // -- r1 : key 208 // -- r1 : key
211 // -- r2 : receiver 209 // -- r2 : receiver
212 // -- lr : return address 210 // -- lr : return address
213 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0); 211 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit(), 0);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 } 314 }
317 315
318 316
319 const bool LiveEdit::kFrameDropperSupported = true; 317 const bool LiveEdit::kFrameDropperSupported = true;
320 318
321 #undef __ 319 #undef __
322 320
323 } } // namespace v8::internal 321 } } // namespace v8::internal
324 322
325 #endif // V8_TARGET_ARCH_ARM 323 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698