Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/debug-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1838 matching lines...) Expand 10 before | Expand all | Expand 10 after
1849 __ cmp(r0, Operand::Zero()); 1849 __ cmp(r0, Operand::Zero());
1850 __ LoadRoot(r0, Heap::kTrueValueRootIndex, eq); 1850 __ LoadRoot(r0, Heap::kTrueValueRootIndex, eq);
1851 __ LoadRoot(r0, Heap::kFalseValueRootIndex, ne); 1851 __ LoadRoot(r0, Heap::kFalseValueRootIndex, ne);
1852 __ Ret(HasArgsInRegisters() ? 0 : 2); 1852 __ Ret(HasArgsInRegisters() ? 0 : 2);
1853 } 1853 }
1854 } 1854 }
1855 1855
1856 1856
1857 void FunctionPrototypeStub::Generate(MacroAssembler* masm) { 1857 void FunctionPrototypeStub::Generate(MacroAssembler* masm) {
1858 Label miss; 1858 Label miss;
1859 Register receiver; 1859 Register receiver = LoadIC::ReceiverRegister();
1860 Register name = LoadIC::NameRegister();
1861
1862 ASSERT(kind() == Code::LOAD_IC ||
1863 kind() == Code::KEYED_LOAD_IC);
1864
1860 if (kind() == Code::KEYED_LOAD_IC) { 1865 if (kind() == Code::KEYED_LOAD_IC) {
1861 // ----------- S t a t e ------------- 1866 __ cmp(name, Operand(isolate()->factory()->prototype_string()));
1862 // -- lr : return address
1863 // -- r0 : key
1864 // -- r1 : receiver
1865 // -----------------------------------
1866 __ cmp(r0, Operand(isolate()->factory()->prototype_string()));
1867 __ b(ne, &miss); 1867 __ b(ne, &miss);
1868 receiver = r1;
1869 } else {
1870 ASSERT(kind() == Code::LOAD_IC);
1871 // ----------- S t a t e -------------
1872 // -- r2 : name
1873 // -- lr : return address
1874 // -- r0 : receiver
1875 // -- sp[0] : receiver
1876 // -----------------------------------
1877 receiver = r0;
1878 } 1868 }
1879 1869
1880 StubCompiler::GenerateLoadFunctionPrototype(masm, receiver, r3, r4, &miss); 1870 StubCompiler::GenerateLoadFunctionPrototype(masm, receiver, r3, r4, &miss);
1881 __ bind(&miss); 1871 __ bind(&miss);
1882 StubCompiler::TailCallBuiltin( 1872 StubCompiler::TailCallBuiltin(
1883 masm, BaseLoadStoreStubCompiler::MissBuiltin(kind())); 1873 masm, BaseLoadStoreStubCompiler::MissBuiltin(kind()));
1884 } 1874 }
1885 1875
1886 1876
1887 Register InstanceofStub::left() { return r0; } 1877 Register InstanceofStub::left() { return r0; }
(...skipping 3194 matching lines...) Expand 10 before | Expand all | Expand 10 after
5082 MemOperand(fp, 6 * kPointerSize), 5072 MemOperand(fp, 6 * kPointerSize),
5083 NULL); 5073 NULL);
5084 } 5074 }
5085 5075
5086 5076
5087 #undef __ 5077 #undef __
5088 5078
5089 } } // namespace v8::internal 5079 } } // namespace v8::internal
5090 5080
5091 #endif // V8_TARGET_ARCH_ARM 5081 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/debug-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698