Log QuicGoAwayFrames and QuicPingFrames, sent and received, in net log.

Log QuicGoAwayFrames and QuicPingFrames, sent and received, in net log.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277861

[jar (doing other things), 2014-06-16 22:47:24]

Thanks for adding the the details to the go_away.  

LGTM % comment nit below.

https://codereview.chromium.org/338933003/diff/40001/net/base/net_log_event_t...
File net/base/net_log_event_type_list.h (right):

https://codereview.chromium.org/338933003/diff/40001/net/base/net_log_event_t...
net/base/net_log_event_type_list.h:1463: // Session received a GOAWAY frame.
nit: Just like documentation in lines 1458-1460, document that is passed for
each of these frames:
"quic_error": <QuicErrorCode in the frame>,
"last_good_stream_id": <Last correctly received stream id by the server>,
"reason_phrase": <Prose justifying go-away request>,


You should use the same description under line 1466.

[Robbie Shade, 2014-06-17 13:48:28]

https://codereview.chromium.org/338933003/diff/40001/net/base/net_log_event_t...
File net/base/net_log_event_type_list.h (right):

https://codereview.chromium.org/338933003/diff/40001/net/base/net_log_event_t...
net/base/net_log_event_type_list.h:1463: // Session received a GOAWAY frame.
On 2014/06/16 22:47:24, jar wrote:
> nit: Just like documentation in lines 1458-1460, document that is passed for
> each of these frames:
> "quic_error": <QuicErrorCode in the frame>,
> "last_good_stream_id": <Last correctly received stream id by the server>,
> "reason_phrase": <Prose justifying go-away request>,
> 
> 
> You should use the same description under line 1466.
> 

Done.

[Robbie Shade, 2014-06-17 13:48:50]

The CQ bit was checked by rjshade@google.com

[commit-bot: I haz the power, 2014-06-17 13:50:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rjshade@google.com/338933003/60001

[commit-bot: I haz the power, 2014-06-17 21:11:01]

Change committed as 277861