src/core/SkBitmap.cpp - Issue 338933002: Cleaned a repeated if(condition) with the same condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmap.cpp

Issue 338933002: Cleaned a repeated if(condition) with the same condition (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmap.cpp

diff --git a/src/core/SkBitmap.cpp b/src/core/SkBitmap.cpp

index dcbba9afb080976c77162628bdd7d7bfc8f5a84f..0490e8f4827aafefc5da8680936fa4599a233093 100644

--- a/src/core/SkBitmap.cpp

+++ b/src/core/SkBitmap.cpp

@@ -295,13 +295,11 @@ SkPixelRef* SkBitmap::setPixelRef(SkPixelRef* pr, int dx, int dy) {

}

if (fPixelRef != pr) {

- if (fPixelRef != pr) {

- this->freePixels();

- SkASSERT(NULL == fPixelRef);

+ this->freePixels();

+ SkASSERT(NULL == fPixelRef);

- SkSafeRef(pr);

- fPixelRef = pr;

- }

+ SkSafeRef(pr);

+ fPixelRef = pr;

this->updatePixelsFromRef();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »