Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 338923003: Clean up DirectWrite typeface cache matching. (Closed)

Created:
6 years, 6 months ago by bungeman-skia
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Clean up DirectWrite typeface cache matching. The matching code was difficult to follow due to naming issues, and performed some duplicate work which is not wanted. This change will either fix the associated bug or make it possible to track the cause. CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite-Trybot BUG=384529 Committed: https://skia.googlesource.com/skia/+/33eb30fed8aa45c47a65e684e1b65da2b2e1fb91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -95 lines) Patch
M src/ports/SkFontMgr_win_dw.cpp View 3 chunks +83 lines, -95 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bungeman-skia
6 years, 6 months ago (2014-06-16 19:06:28 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-16 19:22:00 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-16 22:25:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/338923003/1
6 years, 6 months ago (2014-06-16 22:26:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 23:58:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite-Trybot/builds/37)
6 years, 6 months ago (2014-06-16 23:58:59 UTC) #6
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-17 20:47:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/338923003/1
6 years, 6 months ago (2014-06-17 20:48:07 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 01:12:57 UTC) #9
Message was sent while issue was closed.
Change committed as 33eb30fed8aa45c47a65e684e1b65da2b2e1fb91

Powered by Google App Engine
This is Rietveld 408576698