Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 338913002: Prepare for internal SaveFlags removal. (Closed)

Created:
6 years, 6 months ago by f(malita)
Modified:
6 years, 6 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Prepare for internal SaveFlags removal. Chromium has a couple of SkCanvas subclasses which override willSave(). This adds a transitional shim to facilitate converting these to the parameter-less API. BUG=skia:2297 R=reed@google.com,scroggo@google.com Committed: https://skia.googlesource.com/skia/+/07fc662d7ee018bfc9eeddab82cc1768f57a69d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/core/SkCanvas.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
Re-upload of https://codereview.chromium.org/338833003/ to fix the base URL.
6 years, 6 months ago (2014-06-16 17:58:11 UTC) #1
scroggo
On 2014/06/16 17:58:11, Florin Malita wrote: > Re-upload of https://codereview.chromium.org/338833003/ to fix the base URL. ...
6 years, 6 months ago (2014-06-16 18:34:29 UTC) #2
reed1
won't get a warning about shadowing a virtual with two variants? lgtm
6 years, 6 months ago (2014-06-16 18:38:11 UTC) #3
f(malita)
On 2014/06/16 18:38:11, reed1 wrote: > won't get a warning about shadowing a virtual with ...
6 years, 6 months ago (2014-06-16 18:39:43 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-16 18:58:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/338913002/1
6 years, 6 months ago (2014-06-16 18:58:58 UTC) #6
commit-bot: I haz the power
Change committed as 07fc662d7ee018bfc9eeddab82cc1768f57a69d2
6 years, 6 months ago (2014-06-16 19:13:44 UTC) #7
f(malita)
6 years, 6 months ago (2014-06-17 19:51:43 UTC) #8
Message was sent while issue was closed.
On 2014/06/16 18:39:43, Florin Malita wrote:
> On 2014/06/16 18:38:11, reed1 wrote:
> > won't get a warning about shadowing a virtual with two variants?
> 
> Haven't noticed it on my local clang build, but I'll fire all platform trybots
> to make sure.

Arrr, I see now what you're talking about :( This doesn't trigger warnings in
Skia, but it creates a visibility mess for clients due to subclasses overriding
only one of them.

Powered by Google App Engine
This is Rietveld 408576698