Issue 3389029: Revive TPM firmware autotest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3389029: Revive TPM firmware autotest. (Closed)

Created:
10 years, 3 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
zbehan, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, Luigi Semenzato, Bill Richardson, gauravsh

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

Revive TPM firmware autotest. Change-Id: I2e798ac8898852aa44a8979e67dfa4de385a6e34 BUG=none TEST=ran the autotest on a CRB with special firmware Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9565edc

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : fix tpm_takeownership path #

Total comments: 1

Patch Set 4 : Add TODO. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -52 lines)			Patch
M	autotest/client/hardware_TPMFirmware/hardware_TPMFirmware.py	View	1 2	2 chunks	+8 lines, -32 lines	0 comments	Download
M	autotest/server/hardware_TPMFirmwareServer/hardware_TPMFirmwareServer.py	View	1 2 3	3 chunks	+39 lines, -19 lines	0 comments	Download
M	tests/tpm_lite/testsetup.c	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zbehan

I assume the test has been unused for a while, the list of changes is ...

10 years, 3 months ago (2010-09-23 20:24:56 UTC) #2

gauravsh

10 years, 3 months ago (2010-09-23 21:28:59 UTC) #3

LGTM after you add the TODO

http://codereview.chromium.org/3389029/diff/4001/5002
File autotest/server/hardware_TPMFirmwareServer/hardware_TPMFirmwareServer.py
(right):

http://codereview.chromium.org/3389029/diff/4001/5002#newcode82
autotest/server/hardware_TPMFirmwareServer/hardware_TPMFirmwareServer.py:82:
self.tpm_run("tpmtest_testsetup")
Add a TODO() here as we discussed.

Expand Messages | Collapse Messages