Source/bindings/tests/results/V8TestObject.cpp - Issue 338893004: Extend ScalarValueString handling to include constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 338893004: Extend ScalarValueString handling to include constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tweaks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp

index 5a48ce5bafd61f59998c2656c5abcef238d846b7..17d25bb6ff49aac937dae108c50924f4b867fb63 100644

--- a/Source/bindings/tests/results/V8TestObject.cpp

+++ b/Source/bindings/tests/results/V8TestObject.cpp

@@ -6988,7 +6988,7 @@ static void voidMethodDefaultNullableStringArgMethod(const v8::FunctionCallbackI

TestObject* impl = V8TestObject::toNative(info.Holder());

V8StringResource<> defaultStringArg;

{

- TOSTRING_VOID_INTERNAL(defaultStringArg, info[0]);

+ TOSTRING_VOID_INTERNAL(defaultStringArg, argumentOrNull(info, 0));

}

impl->voidMethodDefaultNullableStringArg(defaultStringArg);

}

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor4.cpp ('k') | no next file » | no next file with comments »