Source/bindings/scripts/v8_attributes.py - Issue 338893004: Extend ScalarValueString handling to include constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 338893004: Extend ScalarValueString handling to include constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Common up more string-related type checks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index d774313bb9b63cba2bad1eb57e6a1a131521ec4e..bd0629338c8d6381fb0d1aca6e8cf10fa0b5f4bd 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -109,8 +109,7 @@ def generate_attribute(interface, attribute):

'has_setter_exception_state':

is_setter_raises_exception or has_type_checking_interface or

has_type_checking_nullable or has_type_checking_unrestricted or

- idl_type.is_integer_type or

- idl_type.name in ('ByteString', 'ScalarValueString'),

+ idl_type.may_raise_exception_on_conversion,

'has_type_checking_interface': has_type_checking_interface,

'has_type_checking_nullable': has_type_checking_nullable,

'has_type_checking_unrestricted': has_type_checking_unrestricted,

« Source/bindings/scripts/idl_types.py ('K') | « Source/bindings/scripts/idl_types.py ('k') | Source/bindings/scripts/v8_interface.py » ('j') | Source/bindings/scripts/v8_methods.py » ('J')