Issue 338883003: Rename arguments object support functions to new scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338883003: Rename arguments object support functions to new scheme. (Closed)

Created:
6 years, 6 months ago by Michael Starzinger

Modified:
6 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x87/code-stubs-x87.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM with nit: the new name sounds slower than the old one :-P

6 years, 6 months ago (2014-06-17 13:43:59 UTC) #2

Michael Starzinger

I will run the benchmarks. If it tanks I will fix in in a follow-up ...

6 years, 6 months ago (2014-06-17 13:46:37 UTC) #3

Michael Starzinger

6 years, 6 months ago (2014-06-17 14:10:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21875 (tree was closed).