Copy media files from chrome/test/data/media and content/test/data/media

Copy media files from chrome/test/data/media and content/test/data/media
into media/test/data.

These files will be used by media browser_tests and content_browsertests.

BUG=379314
R=jrummell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280628

[shadi, 2014-06-24 00:24:29]

These are the media files needed by media content_browsertests and browser_tests
that are not found or different in media/test/data.

[jrummell, 2014-06-24 00:45:18]

lgtm w/question.

https://codereview.chromium.org/338863007/diff/40001/media/test/data/README
File media/test/data/README (right):

https://codereview.chromium.org/338863007/diff/40001/media/test/data/README#n...
media/test/data/README:61: frame_size_change-av_enc-v.webm -
third_party/WebKit/LayoutTests/media/resources/frame_size_change.webm encrypted
using key ID [1] and key [2].
Seems like there are a lot more files being added than are documented in this
file. Is this due to the other files not documented in their current location?

[scherkus (not reviewing), 2014-06-24 00:47:52]

drive-by: is the goal to completely eliminate {content,chrome}/test/data/media/?

[shadi, 2014-06-24 00:53:33]

scherkus: only for videostack (there are still data files there used by
webrtc browser tests in there). For videostack (i.e. EME, MSE, and
video/audio), we will only use media/test/data moving forward.


On Mon, Jun 23, 2014 at 5:47 PM, <scherkus@chromium.org> wrote:

> drive-by: is the goal to completely eliminate {content,chrome}/test/data/
> media/?
>
> https://codereview.chromium.org/338863007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shadi, 2014-06-24 00:57:39]

(In case my comment didn't go through in email)
scherkus: only for videostack (there are still data files there used by webrtc
browser tests in there). For videostack (i.e. EME, MSE, and video/audio), we
will only use media/test/data moving forward.

https://codereview.chromium.org/338863007/diff/40001/media/test/data/README
File media/test/data/README (right):

https://codereview.chromium.org/338863007/diff/40001/media/test/data/README#n...
media/test/data/README:61: frame_size_change-av_enc-v.webm -
third_party/WebKit/LayoutTests/media/resources/frame_size_change.webm encrypted
using key ID [1] and key [2].
On 2014/06/24 00:45:17, jrummell wrote:
> Seems like there are a lot more files being added than are documented in this
> file. Is this due to the other files not documented in their current location?

Correct. I tried to focus on encrypted files which need some documentation
(which I also know what they are used for :).

[scherkus (not reviewing), 2014-06-24 00:59:16]

On 2014/06/24 00:53:33, shadi wrote:
> scherkus: only for videostack (there are still data files there used by
> webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> video/audio), we will only use media/test/data moving forward.

hrmm ... does that make sense for things that aren't shared / have corresponding
.html with them?

in particular I'm thinking of the blackwhite / color format tests.

[shadi, 2014-06-24 16:40:00]

On 2014/06/24 00:59:16, scherkus wrote:
> On 2014/06/24 00:53:33, shadi wrote:
> > scherkus: only for videostack (there are still data files there used by
> > webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> > video/audio), we will only use media/test/data moving forward.
> 
> hrmm ... does that make sense for things that aren't shared / have
corresponding
> .html with them?
> 
> in particular I'm thinking of the blackwhite / color format tests.

I'm not sure what you mean...what is the problem having the blackwhite.html file
and all color format files in media/test/data? 
Whouldn't that also help sharing those files with unittests maybe?

[scherkus (not reviewing), 2014-06-24 17:49:03]

On 2014/06/24 16:40:00, shadi wrote:
> On 2014/06/24 00:59:16, scherkus wrote:
> > On 2014/06/24 00:53:33, shadi wrote:
> > > scherkus: only for videostack (there are still data files there used by
> > > webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> > > video/audio), we will only use media/test/data moving forward.
> > 
> > hrmm ... does that make sense for things that aren't shared / have
> corresponding
> > .html with them?
> > 
> > in particular I'm thinking of the blackwhite / color format tests.
> 
> I'm not sure what you mean...what is the problem having the blackwhite.html
file
> and all color format files in media/test/data? 
> Whouldn't that also help sharing those files with unittests maybe?

in general, we shouldn't move things just for the sake of moving things

typically we only move things into lower-level folders when it must be shared by
multiple higher-level folders

[shadi, 2014-06-24 19:42:30]

On 2014/06/24 17:49:03, scherkus wrote:
> On 2014/06/24 16:40:00, shadi wrote:
> > On 2014/06/24 00:59:16, scherkus wrote:
> > > On 2014/06/24 00:53:33, shadi wrote:
> > > > scherkus: only for videostack (there are still data files there used by
> > > > webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> > > > video/audio), we will only use media/test/data moving forward.
> > > 
> > > hrmm ... does that make sense for things that aren't shared / have
> > corresponding
> > > .html with them?
> > > 
> > > in particular I'm thinking of the blackwhite / color format tests.
> > 
> > I'm not sure what you mean...what is the problem having the blackwhite.html
> file
> > and all color format files in media/test/data? 
> > Whouldn't that also help sharing those files with unittests maybe?
> 
> in general, we shouldn't move things just for the sake of moving things
> 
> typically we only move things into lower-level folders when it must be shared
by
> multiple higher-level folders

The reason is to avoid duplication and making things easier to maintain. Even
though blackwhite.html is not duplicated, it seems better to use one data dir
for media_browsertests. Otherwise it becomes confusing where each test is
loading data from.

[shadi, 2014-06-25 20:36:50]

On 2014/06/24 19:42:30, shadi wrote:
> On 2014/06/24 17:49:03, scherkus wrote:
> > On 2014/06/24 16:40:00, shadi wrote:
> > > On 2014/06/24 00:59:16, scherkus wrote:
> > > > On 2014/06/24 00:53:33, shadi wrote:
> > > > > scherkus: only for videostack (there are still data files there used
by
> > > > > webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> > > > > video/audio), we will only use media/test/data moving forward.
> > > > 
> > > > hrmm ... does that make sense for things that aren't shared / have
> > > corresponding
> > > > .html with them?
> > > > 
> > > > in particular I'm thinking of the blackwhite / color format tests.
> > > 
> > > I'm not sure what you mean...what is the problem having the
blackwhite.html
> > file
> > > and all color format files in media/test/data? 
> > > Whouldn't that also help sharing those files with unittests maybe?
> > 
> > in general, we shouldn't move things just for the sake of moving things
> > 
> > typically we only move things into lower-level folders when it must be
shared
> by
> > multiple higher-level folders
> 
> The reason is to avoid duplication and making things easier to maintain. Even
> though blackwhite.html is not duplicated, it seems better to use one data dir
> for media_browsertests. Otherwise it becomes confusing where each test is
> loading data from.

scherkus: any comments on this? Again, I think any test using/extending
MediaBrowserTest() should load data from one place. Splitting tests within
content_browsertests to load from media/ and others from content/ will be
confusing. The duplication, to begin with, started because some media files were
used in media/ tests only, then content_browsertests used it, then (chrome)
browsertests needed it, etc. The content used by blackwhite tests can be shared
if needed this way.

[scherkus (not reviewing), 2014-06-25 23:29:06]

On 2014/06/25 20:36:50, shadi wrote:
> On 2014/06/24 19:42:30, shadi wrote:
> > On 2014/06/24 17:49:03, scherkus wrote:
> > > On 2014/06/24 16:40:00, shadi wrote:
> > > > On 2014/06/24 00:59:16, scherkus wrote:
> > > > > On 2014/06/24 00:53:33, shadi wrote:
> > > > > > scherkus: only for videostack (there are still data files there used
> by
> > > > > > webrtc browser tests in there). For videostack (i.e. EME, MSE, and
> > > > > > video/audio), we will only use media/test/data moving forward.
> > > > > 
> > > > > hrmm ... does that make sense for things that aren't shared / have
> > > > corresponding
> > > > > .html with them?
> > > > > 
> > > > > in particular I'm thinking of the blackwhite / color format tests.
> > > > 
> > > > I'm not sure what you mean...what is the problem having the
> blackwhite.html
> > > file
> > > > and all color format files in media/test/data? 
> > > > Whouldn't that also help sharing those files with unittests maybe?
> > > 
> > > in general, we shouldn't move things just for the sake of moving things
> > > 
> > > typically we only move things into lower-level folders when it must be
> shared
> > by
> > > multiple higher-level folders
> > 
> > The reason is to avoid duplication and making things easier to maintain.
Even
> > though blackwhite.html is not duplicated, it seems better to use one data
dir
> > for media_browsertests. Otherwise it becomes confusing where each test is
> > loading data from.
> 
> scherkus: any comments on this? Again, I think any test using/extending
> MediaBrowserTest() should load data from one place. Splitting tests within
> content_browsertests to load from media/ and others from content/ will be
> confusing. The duplication, to begin with, started because some media files
were
> used in media/ tests only, then content_browsertests used it, then (chrome)
> browsertests needed it, etc. The content used by blackwhite tests can be
shared
> if needed this way.

thanks for explaining your rationale -- lgtm from me

[shadi, 2014-06-30 18:18:20]

Committed patchset #1 manually as r280628 (presubmit successful).