Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 338863002: Switch to the new SkCanvas::willSave() API. (Closed)

Created:
6 years, 6 months ago by f(malita)
Modified:
6 years, 6 months ago
Reviewers:
malch, Stephen White, reed1
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, krit, loislo+blink_chromium.org, Rik, pdr., eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, jbroman, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, danakj, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Switch to the new SkCanvas::willSave() API. Skia's save() SaveFlags bits are going the way of the dodo. At this point all callers have been updated to always pass kMatrixClip, but SkCanvas subclasses also need to use the new willSave() API. (depends on https://codereview.chromium.org/338833003/ rolling) BUG=skia:2297 R=reed@google.com,senorblanco@chromium.org,malch@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176465

Patch Set 1 #

Patch Set 2 : Rebased layer-canvas-log-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 1 4 chunks +1 line, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsContextRecorder.cpp View 1 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
f(malita)
6 years, 6 months ago (2014-06-16 15:43:15 UTC) #1
malch
On 2014/06/16 15:43:15, Florin Malita wrote: lgtm Thanks!
6 years, 6 months ago (2014-06-16 15:59:17 UTC) #2
Stephen White
LGTM
6 years, 6 months ago (2014-06-16 16:50:21 UTC) #3
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-17 13:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/338863002/1
6 years, 6 months ago (2014-06-17 13:16:39 UTC) #5
f(malita)
The CQ bit was unchecked by fmalita@chromium.org
6 years, 6 months ago (2014-06-17 13:56:17 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-18 21:39:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/338863002/1
6 years, 6 months ago (2014-06-18 21:40:37 UTC) #8
f(malita)
The CQ bit was unchecked by fmalita@chromium.org
6 years, 6 months ago (2014-06-18 22:29:07 UTC) #9
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-18 22:42:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/338863002/20001
6 years, 6 months ago (2014-06-18 22:43:15 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 00:08:33 UTC) #12
Message was sent while issue was closed.
Change committed as 176465

Powered by Google App Engine
This is Rietveld 408576698