Renamed erronous element id refresh_devices to get_devices

chrome/test/data/webrtc/manual/peerconnection_manual.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
  /**
  * See http://dev.w3.org/2011/webrtc/editor/getusermedia.html for more
  * information on getUserMedia. See
  * http://dev.w3.org/2011/webrtc/editor/webrtc.html for more information on
@@ skipping 176 matching lines @@
   var forceIsac = $('force-isac').checked;
   if (forceIsac) {
     forceIsac_();
   } else {
     dontTouchSdp_();
   }
 }
 
 /**
  * Updates the constraints in the getusermedia-constraints text box with a
- * MediaStreamConstraints string. This string is created based on the status of
- * the checkboxes for audio and video. If device enumeration is supported and
- * device source id's are not null they will be added to the constraints string.
- * Fetches the screen size using "screen" in Chrome as we need to pass a max
- * resolution else it defaults to 640x480 in the constraints for screen
- * capturing.
+ *     MediaStreamConstraints string. This string is created based on the state

[phoglund_chromium, 2014/06/19 11:54:35]

Nit: don't indent comments like this.

[jansson, 2014/06/19 13:02:32]

Done.

+ *     of the 'audiosrc' and 'videosrc' checboxes.

[phoglund_chromium, 2014/06/19 11:54:35]

Nit: checkboxes

[jansson, 2014/06/19 13:02:32]

Done.

+ * If device enumeration is supported and device source id's are not null they
+ *     will be added to the constraints string.
  */
 function updateGetUserMediaConstraints() {
-  var audioSelected = $('audiosrc');
-  var videoSelected = $('videosrc');
-  var constraints = {
-    audio: $('audio').checked,
-    video: $('video').checked
+  var selectedAudioDevice = $('audiosrc');
+  var selectedVideoDevice = $('videosrc');
+  var constraints = {audio: $('audio').checked,
+                     video: $('video').checked
   };
 
-  if (audioSelected.disabled == false && videoSelected.disabled == false) {
-    var devices = getSourcesFromField_(audioSelected, videoSelected);
-    if ($('audio').checked == true) {
-      if (devices.audioId != null) {
+  if ($('video').checked) {
+    // Default optional constraints placed here.
+    constraints.video = {optional: [{minWidth: $('video-width').value},
+                                    {minHeight: $('video-height').value},
+                                    {googLeakyBucket: true}]};
+  }
+
+  if (!selectedAudioDevice.disabled && !selectedAudioDevice.disabled) {
+    var devices = getSourcesFromField_(selectedAudioDevice,
+                                       selectedVideoDevice);
+
+    if ($('audio').checked) {
+      if (devices.audioId != null)
         constraints.audio = {optional: [{sourceId: devices.audioId}]};
-      } else {
-        constraints.audio = true;
-      }
     }
-    if ($('video').checked == true) {
-      // Default optional constraints placed here.
-      constraints.video = {optional: [{minWidth: $('video-width').value},
-                                      {minHeight: $('video-height').value},
-                                      {googLeakyBucket: true}]
-      };
-      if (devices.videoId != null) {
+
+    if ($('video').checked) {
+      if (devices.videoId != null)
         constraints.video.optional.push({sourceId: devices.videoId});
-      }
     }
   }
 
   if ($('screencapture').checked) {
     var constraints = {
       audio: $('audio').checked,
       video: {mandatory: {chromeMediaSource: 'screen',
                           maxWidth: screen.width,
                           maxHeight: screen.height}}
     };
-    if ($('audio').checked == true)
+    if ($('audio').checked)
       print_('Audio for screencapture is not implemented yet, please ' +
             'try to set audio = false prior requesting screencapture');
   }
+
   $('getusermedia-constraints').value = JSON.stringify(constraints, null, ' ');
 }
 
 function showServerHelp() {
   alert('You need to build and run a peerconnection_server on some ' +
         'suitable machine. To build it in chrome, just run make/ninja ' +
         'peerconnection_server. Otherwise, read in https://code.google' +
         '.com/searchframe#xSWYf0NTG_Q/trunk/peerconnection/README&q=REA' +
         'DME%20package:webrtc%5C.googlecode%5C.com.');
 }
@@ skipping 42 matching lines @@
   try {
     peerConnection.removeStream(global.localStream);
   } catch (exception) {
     error_('Could not remove stream: ' + exception);
   }
   print_('Removed local stream.');
 }
 
 /**
  * Enumerates the audio and video devices available in Chrome and adds the
- * devices to the HTML elements with Id 'audiosrc' and 'videosrc'.
+ *     devices to the HTML elements with Id 'audiosrc' and 'videosrc'.

[phoglund_chromium, 2014/06/19 11:54:35]

Nit: don't indent here either.

[jansson, 2014/06/19 13:02:32]

Done.

  * Checks if device enumeration is supported and if the 'audiosrc' + 'videosrc'
- * elements exists, if not a debug printout will be displayed.
+ *     elements exists, if not a debug printout will be displayed.
  * If the device label is empty, audio/video + sequence number will be used to
- * populate the name. Also makes sure the children has been loaded in order
- * to update the constraints.
+ *     populate the name. Also makes sure the children has been loaded in order
+ *     to update the constraints.
  */
 function getDevices() {
-  var audio_select = $('audiosrc');
-  var video_select = $('videosrc');
-  var get_devices = $('get-devices');
-  audio_select.innerHTML = '';
-  video_select.innerHTML = '';
+  selectedAudioDevice = $('audiosrc');
+  selectedVideoDevice = $('videosrc');
+  selectedAudioDevice.innerHTML = '';
+  selectedVideoDevice.innerHTML = '';
+
   try {
     eval(MediaStreamTrack.getSources(function() {}));
   } catch (exception) {
-    audio_select.disabled = true;
-    video_select.disabled = true;
-    refresh_devices.disabled = true;
+    selectedAudioDevice.disabled = true;
+    selectedVideoDevice.disabled = true;
+    $('get-devices').disabled = true;
+    $('get-devices-onload').disabled = true;
     updateGetUserMediaConstraints();
     error_('Device enumeration not supported. ' + exception);
   }
+
   MediaStreamTrack.getSources(function(devices) {
     for (var i = 0; i < devices.length; i++) {
       var option = document.createElement('option');
       option.value = devices[i].id;
       option.text = devices[i].label;
+
       if (devices[i].kind == 'audio') {
         if (option.text == '') {
           option.text = devices[i].id;
         }
-        audio_select.appendChild(option);
+        selectedAudioDevice.appendChild(option);
       } else if (devices[i].kind == 'video') {
         if (option.text == '') {
           option.text = devices[i].id;
         }
-        video_select.appendChild(option);
+        selectedVideoDevice.appendChild(option);
       } else {
         error_('Device type ' + devices[i].kind + ' not recognized, ' +
                 'cannot enumerate device. Currently only device types' +
                 '\'audio\' and \'video\' are supported');
         updateGetUserMediaConstraints();
         return;
       }
     }
   });
+
   checkIfDeviceDropdownsArePopulated_();
 }
 
 /**
  * Sets the transform to apply just before setting the local description and
- * sending to the peer.
+ *     sending to the peer.
  * @param {function} transformFunction A function which takes one SDP string as
  *     argument and returns the modified SDP string.
  */
 function setOutgoingSdpTransform(transformFunction) {
   global.transformOutgoingSdp = transformFunction;
 }
 
 /**
  * Sets the MediaConstraints to be used for PeerConnection createAnswer() calls.
  * @param {string} mediaConstraints The constraints, as defined in the
@@ skipping 1011 matching lines @@
 
 /** @private */
 function readResponseHeader_(request, key) {
   var value = request.getResponseHeader(key);
   if (value == null || value.length == 0) {
     error_('Received empty value ' + value +
            ' for response header key ' + key + '.');
   }
   return parseInt(value);
 }