Renamed erronous element id refresh_devices to get_devices

Renamed erronous element id refresh_devices to get_devices.
Simplified the updateGetUserMediaConstraints function.

BUG=None
Test=gjslint, manually setup a call, verified that the constraints are
updated correctly.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278409

[jansson, 2014-06-19 09:33:21]

While testing some more using Firefox I discovered a element ID was incorrectly
named.

Also fixed and simplified the updateGetUserMediaConstraint function for cases
where getSources is not supported (i.e as of now latest Firefox version 30 does
not support it still). When getSources was not supported the optional
constraints would not be added, only the element checked status (audio = true
etc).

[phoglund_chromium, 2014-06-19 10:07:00]

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:212: if
($('video').checked == true) {
Drop the == true (apply throughout)

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:219: if
(audioSelected.disabled == false && videoSelected.disabled == false) {
if (!audioSelected.disabled && !videoSelected) {

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:222: if
($('audio').checked == true) {
Umm, what is audioSelected and videoSelected anyway? Is that the device chosen
by the user in the drop-down list? In that case name it selectedAudioDevice
(audioSelected sounds like the user selected audio which is confusing compared
to $('audio').checked).

[jansson, 2014-06-19 11:45:49]

Thanks for the feedback! 

I also fixed some comments around the getDevices() and
updateGetUserMediaConstraints() functions.

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:212: if
($('video').checked == true) {
On 2014/06/19 10:06:59, phoglund wrote:
> Drop the == true (apply throughout)

Done.

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:219: if
(audioSelected.disabled == false && videoSelected.disabled == false) {
On 2014/06/19 10:06:59, phoglund wrote:
> if (!audioSelected.disabled && !videoSelected) {

Done.

https://codereview.chromium.org/338853008/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection_manual.js:222: if
($('audio').checked == true) {
On 2014/06/19 10:06:59, phoglund wrote:
> Umm, what is audioSelected and videoSelected anyway? Is that the device chosen
> by the user in the drop-down list? In that case name it selectedAudioDevice
> (audioSelected sounds like the user selected audio which is confusing compared
> to $('audio').checked).
Yes you are correct, Fixed it for both getDevices() and
updateGetUserMediaConstraints() as well as some comments.

[phoglund_chromium, 2014-06-19 11:54:36]

lgtm w/ nits

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:197: *    
MediaStreamConstraints string. This string is created based on the state
Nit: don't indent comments like this.

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:198: *     of the
'audiosrc' and 'videosrc' checboxes.
Nit: checkboxes

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:305: *     devices to
the HTML elements with Id 'audiosrc' and 'videosrc'.
Nit: don't indent here either.

[jansson, 2014-06-19 13:02:32]

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:197: *    
MediaStreamConstraints string. This string is created based on the state
On 2014/06/19 11:54:35, phoglund wrote:
> Nit: don't indent comments like this.

Done.

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:198: *     of the
'audiosrc' and 'videosrc' checboxes.
On 2014/06/19 11:54:35, phoglund wrote:
> Nit: checkboxes

Done.

https://codereview.chromium.org/338853008/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:305: *     devices to
the HTML elements with Id 'audiosrc' and 'videosrc'.
On 2014/06/19 11:54:35, phoglund wrote:
> Nit: don't indent here either.

Done.

[jansson, 2014-06-19 13:02:39]

The CQ bit was checked by jansson@chromium.org

[commit-bot: I haz the power, 2014-06-19 13:04:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jansson@chromium.org/338853008/40001

[commit-bot: I haz the power, 2014-06-19 17:01:46]

Change committed as 278409