Issue 338833008: Require the cursor to move a minimum distance after the mouse press before initiating a mouse drag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338833008: Require the cursor to move a minimum distance after the mouse press before initiating a mouse drag (Closed)

Created:
6 years, 6 months ago by pkotwicz

Modified:
6 years, 6 months ago

Reviewers:
Mr4D (OOO till 08-26)

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Require the cursor to move a minimum distance after the mouse press before initiating a mouse drag. The CL also makes ShelfViewTest send ui::MouseEvents in the coordinates of |ShelfView::drag_view_|. BUG=377522 TEST=ShelfViewTest.ClickAndMoveSlightly Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278129

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -10 lines)			Patch
M	ash/shelf/shelf_view.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/shelf/shelf_view.cc	View	5 chunks	+5 lines, -6 lines	0 comments	Download
M	ash/shelf/shelf_view_unittest.cc	View	4 chunks	+77 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/338833008/40001

6 years, 6 months ago (2014-06-18 14:51:10 UTC) #4

Message was sent while issue was closed.

Change committed as 278129

Expand Messages | Collapse Messages