Issue 338833003: Prepare for internal SaveFlags removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338833003: Prepare for internal SaveFlags removal. (Closed)

Created:
6 years, 6 months ago by f(malita)

Modified:
6 years, 6 months ago

Reviewers:
scroggo, reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Prepare for internal SaveFlags removal. Chromium has a couple of SkCanvas subclasses which override willSave(). This adds a transitional shim to facilitate converting these to the parameter-less API. R=reed@google.com

Patch Set 1 #

Patch Set 2 : Speculative baseurl fix #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	include/core/SkCanvas.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

f(malita)

Leon, do you know of any Android SkCanvas subclasses which may override willSave()? I don't ...

6 years, 6 months ago (2014-06-16 14:17:32 UTC) #2

scroggo

On 2014/06/16 14:17:32, Florin Malita wrote: > Leon, do you know of any Android SkCanvas ...

6 years, 6 months ago (2014-06-16 14:46:30 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-16 16:54:43 UTC) #5

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years, 6 months ago (2014-06-16 16:54:43 UTC) #6

f(malita)

6 years, 6 months ago (2014-06-16 17:58:40 UTC) #7

On 2014/06/16 16:54:43, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Re-uploaded as https://codereview.chromium.org/338913002/ to fix the base URL.

Expand Messages | Collapse Messages