Issue 338833002: Factor out NullExecutionContext from unittest files.

Issue 338833002: Factor out NullExecutionContext from unittest files. (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, alecflett, sof, eae+blinkwatch, ericu+idb_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, dgrogan, cmumford, jsbell+idb_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Factor out NullExecutionContext from unittest files. R=haraken,sof BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176279

Patch Set 4 : Addressed #2 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -110 lines)			Patch
M	Source/core/core.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/MainThreadTaskRunnerTest.cpp	View	1 2 3	3 chunks	+7 lines, -59 lines	0 comments	Download
A	Source/core/testing/NullExecutionContext.h	View	1 2 3	1 chunk	+57 lines, -0 lines	0 comments	Download
A	Source/core/testing/NullExecutionContext.cpp	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequestTest.cpp	View		2 chunks	+9 lines, -51 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sof

https://codereview.chromium.org/338833002/diff/40001/Source/core/testing/NullExecutionContext.h File Source/core/testing/NullExecutionContext.h (right): https://codereview.chromium.org/338833002/diff/40001/Source/core/testing/NullExecutionContext.h#newcode25 Source/core/testing/NullExecutionContext.h:25: void setTasksNeedSuspention(bool flag) { m_tasksNeedSuspension = flag; } Fix ...

6 years, 6 months ago (2014-06-16 14:30:53 UTC) #2

tyoshino (SeeGerritForStatus)

Thanks https://codereview.chromium.org/338833002/diff/40001/Source/core/testing/NullExecutionContext.h File Source/core/testing/NullExecutionContext.h (right): https://codereview.chromium.org/338833002/diff/40001/Source/core/testing/NullExecutionContext.h#newcode25 Source/core/testing/NullExecutionContext.h:25: void setTasksNeedSuspention(bool flag) { m_tasksNeedSuspension = flag; } ...

6 years, 6 months ago (2014-06-17 01:55:45 UTC) #4

tyoshino (SeeGerritForStatus)

The CQ bit was checked by tyoshino@chromium.org

6 years, 6 months ago (2014-06-17 01:56:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/338833002/60001

6 years, 6 months ago (2014-06-17 01:57:04 UTC) #6

Message was sent while issue was closed.

Change committed as 176279

Expand Messages | Collapse Messages