Issue 3388008: Fix one-time init

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3388008: Fix one-time init (Closed)

Created:
10 years, 3 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson, Luigi Semenzato

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Fix one-time init Change-Id: Ie8b4f5b1b7493b16b69eb41531ec3362d4b3679f BUG=chrome-os-partner:1101 TEST=manual testing of affected TPM on CRB

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
	M	firmware/lib/rollback_index.c	View	1	1 chunk	+20 lines, -5 lines	0 comments	Download
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Luigi Semenzato

10 years, 3 months ago (2010-09-15 22:35:26 UTC) #2

LGTM after removing the (wrong) ownership test and force-clearing the TPM
unconditionally, which is totally reasonable at this point.