Issue 338793004: More set_map() calls replaced with MigrateToMap().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338793004: More set_map() calls replaced with MigrateToMap(). (Closed)

Created:
6 years, 6 months ago by Igor Sheludko

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

More set_map() calls replaced with MigrateToMap(). R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21983

Patch Set 2 : Addressing comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -37 lines)			Patch
M	src/api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/bootstrapper.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	src/factory.cc	View	1	3 chunks	+9 lines, -8 lines	0 comments	Download
M	src/objects.cc	View	1	7 chunks	+13 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with comment https://codereview.chromium.org/338793004/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/338793004/diff/1/src/factory.cc#newcode1824 src/factory.cc:1824: object->address() + map->instance_size(), size_difference); AdjustLiveBytes?

6 years, 6 months ago (2014-06-24 13:15:13 UTC) #2

Igor Sheludko

https://codereview.chromium.org/338793004/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/338793004/diff/1/src/factory.cc#newcode1824 src/factory.cc:1824: object->address() + map->instance_size(), size_difference); On 2014/06/24 13:15:13, Toon Verwaest ...

6 years, 6 months ago (2014-06-24 13:55:54 UTC) #3

Igor Sheludko

6 years, 6 months ago (2014-06-24 14:53:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21983 (presubmit successful).

Expand Messages | Collapse Messages

Issue 338793004: More set_map() calls replaced with MigrateToMap(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing comments #

Messages